Skip to content

Commit 06844da

Browse files
committed
Update book
Signed-off-by: Adrian Orive <[email protected]> #1118
1 parent dc32e46 commit 06844da

File tree

1 file changed

+2
-4
lines changed
  • docs/book/src/cronjob-tutorial/testdata/project

1 file changed

+2
-4
lines changed

docs/book/src/cronjob-tutorial/testdata/project/main.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import (
2020
"flag"
2121
"os"
2222

23-
kbatchv1 "k8s.io/api/batch/v1"
2423
"k8s.io/apimachinery/pkg/runtime"
2524
clientgoscheme "k8s.io/client-go/kubernetes/scheme"
2625
_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
@@ -38,8 +37,8 @@ The first difference to notice is that kubebuilder has added the new API
3837
group's package (`batchv1`) to our scheme. This means that we can use those
3938
objects in our controller.
4039
41-
We'll also need to add the kubernetes batch v1 (`kbatchv1`) scheme, since we're creating
42-
and listing Jobs.
40+
If we would be using any other CRD we would have to add their scheme the same way.
41+
Builtin types such as Job have their scheme added by `clientgoscheme`.
4342
*/
4443
var (
4544
scheme = runtime.NewScheme()
@@ -49,7 +48,6 @@ var (
4948
func init() {
5049
_ = clientgoscheme.AddToScheme(scheme)
5150

52-
_ = kbatchv1.AddToScheme(scheme) // we've added this ourselves
5351
_ = batchv1.AddToScheme(scheme)
5452
// +kubebuilder:scaffold:scheme
5553
}

0 commit comments

Comments
 (0)