Merge pull request #1190 from justinsb/dont_rewrite_shared_vars

Avoid rewriting template values, mark them as const

Author: k8s-ci-robot

pkg/scaffold/project/authproxyrole.go

@@ -38,7 +38,7 @@ func (r *AuthProxyRole) GetInput() (input.Input, error) {
 	return r.Input, nil
 }
 
-var proxyRoleTemplate = `apiVersion: rbac.authorization.k8s.io/v1
+const proxyRoleTemplate = `apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
   name: proxy-role

pkg/scaffold/project/authproxyrolebinding.go

@@ -38,7 +38,7 @@ func (r *AuthProxyRoleBinding) GetInput() (input.Input, error) {
 	return r.Input, nil
 }
 
-var proxyRoleBindinggTemplate = `apiVersion: rbac.authorization.k8s.io/v1
+const proxyRoleBindinggTemplate = `apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
   name: proxy-rolebinding

pkg/scaffold/project/boilerplate.go

@@ -65,7 +65,7 @@ func (c *Boilerplate) GetInput() (input.Input, error) {
 	return c.Input, nil
 }
 
-var apache = `/*
+const apache = `/*
 {{ if .Owner }}Copyright {{ .Year }} {{ .Owner }}.
 {{ end }}
 Licensed under the Apache License, Version 2.0 (the "License");
@@ -81,6 +81,6 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */`
 
-var none = `/*
+const none = `/*
 {{ if .Owner }}Copyright {{ .Year }} {{ .Owner }}{{ end }}.
 */`

pkg/scaffold/project/gitignore.go

@@ -36,7 +36,7 @@ func (c *GitIgnore) GetInput() (input.Input, error) {
 	return c.Input, nil
 }
 
-var gitignoreTemplate = `
+const gitignoreTemplate = `
 # Binaries for programs and plugins
 *.exe
 *.exe~

pkg/scaffold/project/gopkg.go

@@ -134,7 +134,7 @@ const DefaultGopkgUserContent = `required = [
 
 `
 
-var depTemplate = `{{ .UserContent }}
+const depTemplate = `{{ .UserContent }}
 # STANZAS BELOW ARE GENERATED AND MAY BE WRITTEN - DO NOT MODIFY BELOW THIS LINE.
 
 {{ range $element := .Stanzas -}}

pkg/scaffold/project/kustomize.go

@@ -51,7 +51,7 @@ func (c *Kustomize) GetInput() (input.Input, error) {
 	return c.Input, nil
 }
 
-var kustomizeTemplate = `# Adds namespace to all resources.
+const kustomizeTemplate = `# Adds namespace to all resources.
 namespace: {{.Prefix}}-system
 
 # Value of this field is prepended to the

pkg/scaffold/project/kustomize_manager_base.go

@@ -39,6 +39,6 @@ func (c *KustomizeManager) GetInput() (input.Input, error) {
 	return c.Input, nil
 }
 
-var kustomizeManagerTemplate = `resources:
+const kustomizeManagerTemplate = `resources:
 - manager.yaml
 `

pkg/scaffold/project/kustomize_rbac_base.go

@@ -39,7 +39,7 @@ func (c *KustomizeRBAC) GetInput() (input.Input, error) {
 	return c.Input, nil
 }
 
-var kustomizeRBACTemplate = `resources:
+const kustomizeRBACTemplate = `resources:
 - rbac_role.yaml
 - rbac_role_binding.yaml
   # Comment the following 3 lines if you want to disable

pkg/scaffold/project/makefile.go

@@ -48,7 +48,7 @@ func (c *Makefile) GetInput() (input.Input, error) {
 	return c.Input, nil
 }
 
-var makefileTemplate = `
+const makefileTemplate = `
 # Image URL to use all building/pushing image targets
 IMG ?= {{ .Image }}
 

pkg/scaffold/v1/authproxyservice.go

@@ -38,7 +38,7 @@ func (r *AuthProxyService) GetInput() (input.Input, error) {
 	return r.Input, nil
 }
 
-var AuthProxyServiceTemplate = `apiVersion: v1
+const AuthProxyServiceTemplate = `apiVersion: v1
 kind: Service
 metadata:
   annotations: