Skip to content

Commit 4d00eb5

Browse files
committed
Remove noop validations
Signed-off-by: Adrian Orive <[email protected]>
1 parent 5dc6055 commit 4d00eb5

18 files changed

+0
-91
lines changed

pkg/model/resource/resource.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,6 @@ type Resource struct {
5454
CreateExampleReconcileBody bool `json:"-"`
5555
}
5656

57-
// Validate checks the Resource values to make sure they are valid.
58-
func (r *Resource) Validate() error {
59-
// TODO: remove when all calls have been removed
60-
return nil
61-
}
62-
6357
func (r *Resource) GVK() config.GVK {
6458
return config.GVK{
6559
Group: r.Group,

pkg/scaffold/internal/templates/v1/crd/addtoscheme.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,6 @@ func (f *AddToScheme) SetTemplateDefaults() error {
4444
return nil
4545
}
4646

47-
// Validate validates the values
48-
func (f *AddToScheme) Validate() error {
49-
return f.Resource.Validate()
50-
}
51-
5247
// NB(directxman12): we need that package alias on the API import otherwise imports.Process
5348
// gets wicked (or hella, if you're feeling west-coasty) confused.
5449

pkg/scaffold/internal/templates/v1/crd/crd_sample.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,6 @@ func (f *CRDSample) SetTemplateDefaults() error {
4747
return nil
4848
}
4949

50-
// Validate validates the values
51-
func (f *CRDSample) Validate() error {
52-
return f.Resource.Validate()
53-
}
54-
5550
const crdSampleTemplate = `apiVersion: {{ .Resource.Domain }}/{{ .Resource.Version }}
5651
kind: {{ .Resource.Kind }}
5752
metadata:

pkg/scaffold/internal/templates/v1/crd/doc.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@ func (f *Doc) SetTemplateDefaults() error {
4343
return nil
4444
}
4545

46-
// Validate validates the values
47-
func (f *Doc) Validate() error {
48-
return f.Resource.Validate()
49-
}
50-
5146
// nolint:lll
5247
const docGoTemplate = `{{ .Boilerplate }}
5348

pkg/scaffold/internal/templates/v1/crd/group.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,6 @@ func (f *Group) SetTemplateDefaults() error {
4242
return nil
4343
}
4444

45-
// Validate validates the values
46-
func (f *Group) Validate() error {
47-
return f.Resource.Validate()
48-
}
49-
5045
const groupTemplate = `{{ .Boilerplate }}
5146
5247
// Package {{ .Resource.GroupPackageName }} contains {{ .Resource.Group }} API versions

pkg/scaffold/internal/templates/v1/crd/register.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@ func (f *Register) SetTemplateDefaults() error {
4343
return nil
4444
}
4545

46-
// Validate validates the values
47-
func (f *Register) Validate() error {
48-
return f.Resource.Validate()
49-
}
50-
5146
// nolint:lll
5247
const registerTemplate = `{{ .Boilerplate }}
5348

pkg/scaffold/internal/templates/v1/crd/types.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,6 @@ func (f *Types) SetTemplateDefaults() error {
4747
return nil
4848
}
4949

50-
// Validate validates the values
51-
func (f *Types) Validate() error {
52-
return f.Resource.Validate()
53-
}
54-
5550
const typesTemplate = `{{ .Boilerplate }}
5651
5752
package {{ .Resource.Version }}

pkg/scaffold/internal/templates/v1/crd/typestest.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,6 @@ func (f *TypesTest) SetTemplateDefaults() error {
4747
return nil
4848
}
4949

50-
// Validate validates the values
51-
func (f *TypesTest) Validate() error {
52-
return f.Resource.Validate()
53-
}
54-
5550
const typesTestTemplate = `{{ .Boilerplate }}
5651
5752
package {{ .Resource.Version }}

pkg/scaffold/internal/templates/v1/crd/version_suitetest.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,6 @@ func (f *VersionSuiteTest) SetTemplateDefaults() error {
4444
return nil
4545
}
4646

47-
// Validate validates the values
48-
func (f *VersionSuiteTest) Validate() error {
49-
return f.Resource.Validate()
50-
}
51-
5247
const versionSuiteTestTemplate = `{{ .Boilerplate }}
5348
5449
package {{ .Resource.Version }}

pkg/scaffold/internal/templates/v2/controller/controller_suitetest.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,6 @@ func (f *SuiteTest) SetTemplateDefaults() error {
5353
return nil
5454
}
5555

56-
// Validate validates the values
57-
func (f *SuiteTest) Validate() error {
58-
return f.Resource.Validate()
59-
}
60-
6156
const (
6257
importMarker = "imports"
6358
addSchemeMarker = "scheme"

0 commit comments

Comments
 (0)