Skip to content

Commit 52f1315

Browse files
authored
Merge pull request #3038 from krishnaindani/update-cronjob-api-version
📖 update cronjob to use batchv1 api instead of v1beta1
2 parents 68bedfc + 2035b6f commit 52f1315

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

docs/book/src/cronjob-tutorial/testdata/project/api/v1/cronjob_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ package v1
2222
/*
2323
*/
2424
import (
25-
batchv1beta1 "k8s.io/api/batch/v1beta1"
25+
batchv1 "k8s.io/api/batch/v1"
2626
corev1 "k8s.io/api/core/v1"
2727
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2828
)
@@ -88,7 +88,7 @@ type CronJobSpec struct {
8888
Suspend *bool `json:"suspend,omitempty"`
8989

9090
// Specifies the job that will be created when executing a CronJob.
91-
JobTemplate batchv1beta1.JobTemplateSpec `json:"jobTemplate"`
91+
JobTemplate batchv1.JobTemplateSpec `json:"jobTemplate"`
9292

9393
//+kubebuilder:validation:Minimum=0
9494

docs/book/src/cronjob-tutorial/testdata/project/controllers/cronjob_controller_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import (
3232
. "github.com/onsi/ginkgo/v2"
3333
. "github.com/onsi/gomega"
3434
batchv1 "k8s.io/api/batch/v1"
35-
batchv1beta1 "k8s.io/api/batch/v1beta1"
3635
v1 "k8s.io/api/core/v1"
3736
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3837
"k8s.io/apimachinery/pkg/types"
@@ -78,7 +77,7 @@ var _ = Describe("CronJob controller", func() {
7877
},
7978
Spec: cronjobv1.CronJobSpec{
8079
Schedule: "1 * * * *",
81-
JobTemplate: batchv1beta1.JobTemplateSpec{
80+
JobTemplate: batchv1.JobTemplateSpec{
8281
Spec: batchv1.JobSpec{
8382
// For simplicity, we only fill out the required fields.
8483
Template: v1.PodTemplateSpec{

docs/book/src/multiversion-tutorial/testdata/project/api/v1/cronjob_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ package v1
2222
/*
2323
*/
2424
import (
25-
batchv1beta1 "k8s.io/api/batch/v1beta1"
25+
batchv1 "k8s.io/api/batch/v1"
2626
corev1 "k8s.io/api/core/v1"
2727
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2828
)
@@ -60,7 +60,7 @@ type CronJobSpec struct {
6060
Suspend *bool `json:"suspend,omitempty"`
6161

6262
// Specifies the job that will be created when executing a CronJob.
63-
JobTemplate batchv1beta1.JobTemplateSpec `json:"jobTemplate"`
63+
JobTemplate batchv1.JobTemplateSpec `json:"jobTemplate"`
6464

6565
// +kubebuilder:validation:Minimum=0
6666

docs/book/src/multiversion-tutorial/testdata/project/api/v2/cronjob_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ package v2
2525
/*
2626
*/
2727
import (
28-
batchv1beta1 "k8s.io/api/batch/v1beta1"
28+
batchv1 "k8s.io/api/batch/v1"
2929
corev1 "k8s.io/api/core/v1"
3030
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3131
)
@@ -67,7 +67,7 @@ type CronJobSpec struct {
6767
Suspend *bool `json:"suspend,omitempty"`
6868

6969
// Specifies the job that will be created when executing a CronJob.
70-
JobTemplate batchv1beta1.JobTemplateSpec `json:"jobTemplate"`
70+
JobTemplate batchv1.JobTemplateSpec `json:"jobTemplate"`
7171

7272
// +kubebuilder:validation:Minimum=0
7373

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
exampleTarget
1+
exampleTargetexampleCodeexampleCode

0 commit comments

Comments
 (0)