Skip to content

Commit 5a78c19

Browse files
authored
Merge pull request #1843 from estroz/chore/fix-build-variables
🌱 Makefile,build/.goreleaser.yml: fix ldflag variable setting
2 parents 9663fb3 + 5f17b7b commit 5a78c19

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ help: ## Display this help
3939
##@ Build
4040

4141
LD_FLAGS=-ldflags " \
42-
-X sigs.k8s.io/kubebuilder/v2/cmd.kubeBuilderVersion=$(shell git describe --tags --dirty --broken) \
43-
-X sigs.k8s.io/kubebuilder/v2/cmd.goos=$(shell go env GOOS) \
44-
-X sigs.k8s.io/kubebuilder/v2/cmd.goarch=$(shell go env GOARCH) \
45-
-X sigs.k8s.io/kubebuilder/v2/cmd.gitCommit=$(shell git rev-parse HEAD) \
46-
-X sigs.k8s.io/kubebuilder/v2/cmd.buildDate=$(shell date -u +'%Y-%m-%dT%H:%M:%SZ') \
42+
-X main.kubeBuilderVersion=$(shell git describe --tags --dirty --broken) \
43+
-X main.goos=$(shell go env GOOS) \
44+
-X main.goarch=$(shell go env GOARCH) \
45+
-X main.gitCommit=$(shell git rev-parse HEAD) \
46+
-X main.buildDate=$(shell date -u +'%Y-%m-%dT%H:%M:%SZ') \
4747
"
4848
.PHONY: build
4949
build: ## Build the project locally

build/.goreleaser.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,14 @@
1717
builds:
1818
- main: ./cmd
1919
binary: kubebuilder
20-
ldflags: -s -X sigs.k8s.io/kubebuilder/v2/cmd.kubeBuilderVersion={{.Version}} -X sigs.k8s.io/kubebuilder/v2/cmd.gitCommit={{.Commit}} -X sigs.k8s.io/kubebuilder/v2/cmd.buildDate={{.Date}} -X sigs.k8s.io/kubebuilder/v2/cmd.kubernetesVendorVersion={{.Env.KUBERNETES_VERSION}}
20+
ldflags:
21+
- -s
22+
- -X main.kubeBuilderVersion={{.Version}}
23+
- -X main.goos={{.Os}}
24+
- -X main.goarch={{.Arch}}
25+
- -X main.gitCommit={{.Commit}}
26+
- -X main.buildDate={{.Date}}
27+
- -X main.kubernetesVendorVersion={{.Env.KUBERNETES_VERSION}}
2128
goos:
2229
- darwin
2330
- linux

0 commit comments

Comments
 (0)