Skip to content

Commit 615f8c2

Browse files
authored
Merge pull request #2033 from Adirio/cleanup-todos
🌱 Update old TODOs that are no longer valid
2 parents 2d9367e + 7a7a66f commit 615f8c2

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

pkg/config/v3/config_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,8 +499,7 @@ var _ = Describe("cfg", func() {
499499
},
500500
},
501501
}
502-
// TODO: include cases with Plural, Path, API.namespaced, Controller, Webhooks.Defaulting,
503-
// Webhooks.Validation and Webhooks.Conversion when added
502+
// TODO: include cases with Path when added
504503
s1 = `domain: my.domain
505504
layout: go.kubebuilder.io/v2
506505
projectName: ProjectName

pkg/plugins/golang/v2/scaffolds/internal/templates/main.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,6 @@ const (
9292
`
9393
controllerImportCodeFragment = `"%s/controllers"
9494
`
95-
// TODO(v3): `&%scontrollers` should be used instead of `&%scontroller` as there may be multiple
96-
// controller for different Kinds in the same group. However, this is a backwards incompatible
97-
// change, and thus should be done for next project version.
9895
multiGroupControllerImportCodeFragment = `%scontroller "%s/controllers/%s"
9996
`
10097
addschemeCodeFragment = `utilruntime.Must(%s.AddToScheme(scheme))
@@ -108,9 +105,6 @@ const (
108105
os.Exit(1)
109106
}
110107
`
111-
// TODO(v3): loggers for the same Kind controllers from different groups use the same logger.
112-
// `.WithName("controllers").WithName(GROUP).WithName(KIND)` should be used instead. However,
113-
// this is a backwards incompatible change, and thus should be done for next project version.
114108
multiGroupReconcilerSetupCodeFragment = `if err = (&%scontroller.%sReconciler{
115109
Client: mgr.GetClient(),
116110
Log: ctrl.Log.WithName("controllers").WithName("%s"),

0 commit comments

Comments
 (0)