Fix lint issues: shadow declaration, goimports, and code duplication

Co-authored-by: camilamacedo86 <[email protected]>

Author: Copilot

pkg/plugins/external/edit.go

@@ -42,11 +42,13 @@ func (p *editSubcommand) BindFlags(fs *pflag.FlagSet) {
 	bindExternalPluginFlags(fs, "edit", p.Path, p.Args)
 }
 
+//nolint:dupl
 func (p *editSubcommand) InjectConfig(c config.Config) error {
 	p.config = c
 	return nil
 }
 
+//nolint:dupl
 func (p *editSubcommand) Scaffold(fs machinery.Filesystem) error {
 	req := external.PluginRequest{
 		APIVersion: defaultAPIVersion,

pkg/plugins/external/external_test.go

@@ -28,7 +28,7 @@ import (
 	"github.com/spf13/afero"
 	"github.com/spf13/pflag"
 
-	"sigs.k8s.io/kubebuilder/v4/pkg/config/v3"
+	v3 "sigs.k8s.io/kubebuilder/v4/pkg/config/v3"
 	"sigs.k8s.io/kubebuilder/v4/pkg/machinery"
 	"sigs.k8s.io/kubebuilder/v4/pkg/plugin"
 	"sigs.k8s.io/kubebuilder/v4/pkg/plugin/external"

pkg/plugins/external/helpers.go

@@ -161,7 +161,8 @@ func handlePluginResponse(fs machinery.Filesystem, req external.PluginRequest, p
 
 	// Marshal config to include in the request if config is provided
 	if cfg != nil {
-		configData, err := cfg.MarshalYAML()
+		var configData []byte
+		configData, err = cfg.MarshalYAML()
 		if err != nil {
 			return fmt.Errorf("error marshaling config: %w", err)
 		}

pkg/plugins/external/init.go

@@ -42,11 +42,13 @@ func (p *initSubcommand) BindFlags(fs *pflag.FlagSet) {
 	bindExternalPluginFlags(fs, "init", p.Path, p.Args)
 }
 
+//nolint:dupl
 func (p *initSubcommand) InjectConfig(c config.Config) error {
 	p.config = c
 	return nil
 }
 
+//nolint:dupl
 func (p *initSubcommand) Scaffold(fs machinery.Filesystem) error {
 	req := external.PluginRequest{
 		APIVersion: defaultAPIVersion,