Skip to content

Commit 66c1957

Browse files
authored
Merge pull request #5493 from camilamacedo86/fix-linter-issue
🐛 (go/v4): CI lint by using make lint instead of golangci-lint-action so the custom binary (with logcheck plugin) is built and used.
2 parents 94434cd + 2fe50b5 commit 66c1957

File tree

7 files changed

+21
-21
lines changed
  • docs/book/src
    • cronjob-tutorial/testdata/project/.github/workflows
    • getting-started/testdata/project/.github/workflows
    • multiversion-tutorial/testdata/project/.github/workflows
  • pkg/plugins/golang/v4/scaffolds/internal/templates/github
  • testdata
    • project-v4-multigroup/.github/workflows
    • project-v4-with-plugins/.github/workflows
    • project-v4/.github/workflows

7 files changed

+21
-21
lines changed

docs/book/src/cronjob-tutorial/testdata/project/.github/workflows/lint.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
with:
1818
go-version-file: go.mod
1919

20+
- name: Check linter configuration
21+
run: make lint-config
2022
- name: Run linter
21-
uses: golangci/golangci-lint-action@v8
22-
with:
23-
version: v2.8.0
23+
run: make lint

docs/book/src/getting-started/testdata/project/.github/workflows/lint.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
with:
1818
go-version-file: go.mod
1919

20+
- name: Check linter configuration
21+
run: make lint-config
2022
- name: Run linter
21-
uses: golangci/golangci-lint-action@v8
22-
with:
23-
version: v2.8.0
23+
run: make lint

docs/book/src/multiversion-tutorial/testdata/project/.github/workflows/lint.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
with:
1818
go-version-file: go.mod
1919

20+
- name: Check linter configuration
21+
run: make lint-config
2022
- name: Run linter
21-
uses: golangci/golangci-lint-action@v8
22-
with:
23-
version: v2.8.0
23+
run: make lint

pkg/plugins/golang/v4/scaffolds/internal/templates/github/lint.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ jobs:
6565
with:
6666
go-version-file: go.mod
6767
68+
- name: Check linter configuration
69+
run: make lint-config
6870
- name: Run linter
69-
uses: golangci/golangci-lint-action@v8
70-
with:
71-
version: {{ .GolangciLintVersion }}
71+
run: make lint
7272
`

testdata/project-v4-multigroup/.github/workflows/lint.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
with:
1818
go-version-file: go.mod
1919

20+
- name: Check linter configuration
21+
run: make lint-config
2022
- name: Run linter
21-
uses: golangci/golangci-lint-action@v8
22-
with:
23-
version: v2.8.0
23+
run: make lint

testdata/project-v4-with-plugins/.github/workflows/lint.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
with:
1818
go-version-file: go.mod
1919

20+
- name: Check linter configuration
21+
run: make lint-config
2022
- name: Run linter
21-
uses: golangci/golangci-lint-action@v8
22-
with:
23-
version: v2.8.0
23+
run: make lint

testdata/project-v4/.github/workflows/lint.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
with:
1818
go-version-file: go.mod
1919

20+
- name: Check linter configuration
21+
run: make lint-config
2022
- name: Run linter
21-
uses: golangci/golangci-lint-action@v8
22-
with:
23-
version: v2.8.0
23+
run: make lint

0 commit comments

Comments
 (0)