Fix e2e test to validate that metrics are exported without asserting a controller-specific metric

Author: camilamacedo86

docs/book/src/cronjob-tutorial/testdata/project/test/e2e/e2e_test.go

@@ -260,9 +260,8 @@ var _ = Describe("Manager", Ordered, func() {
 
 			By("getting the metrics by checking curl-metrics logs")
 			metricsOutput := getMetricsOutput()
-			Expect(metricsOutput).To(ContainSubstring(
-				"controller_runtime_reconcile_total",
-			))
+			Expect(metricsOutput).NotTo(BeEmpty())
+			Expect(metricsOutput).To(ContainSubstring("# TYPE"))
 		})
 
 		It("should provisioned cert-manager", func() {

docs/book/src/getting-started/testdata/project/test/e2e/e2e_test.go

@@ -255,9 +255,8 @@ var _ = Describe("Manager", Ordered, func() {
 
 			By("getting the metrics by checking curl-metrics logs")
 			metricsOutput := getMetricsOutput()
-			Expect(metricsOutput).To(ContainSubstring(
-				"controller_runtime_reconcile_total",
-			))
+			Expect(metricsOutput).NotTo(BeEmpty())
+			Expect(metricsOutput).To(ContainSubstring("# TYPE"))
 		})
 
 		// +kubebuilder:scaffold:e2e-webhooks-checks

docs/book/src/multiversion-tutorial/testdata/project/test/e2e/e2e_test.go

@@ -260,9 +260,8 @@ var _ = Describe("Manager", Ordered, func() {
 
 			By("getting the metrics by checking curl-metrics logs")
 			metricsOutput := getMetricsOutput()
-			Expect(metricsOutput).To(ContainSubstring(
-				"controller_runtime_reconcile_total",
-			))
+			Expect(metricsOutput).NotTo(BeEmpty())
+			Expect(metricsOutput).To(ContainSubstring("# TYPE"))
 		})
 
 		It("should provisioned cert-manager", func() {

pkg/plugins/golang/v4/scaffolds/internal/templates/test/e2e/test.go

@@ -438,9 +438,8 @@ var _ = Describe("Manager", Ordered, func() {
 
 			By("getting the metrics by checking curl-metrics logs")
 			metricsOutput := getMetricsOutput()
-			Expect(metricsOutput).To(ContainSubstring(
-				"controller_runtime_reconcile_total",
-			))
+			Expect(metricsOutput).NotTo(BeEmpty())
+			Expect(metricsOutput).To(ContainSubstring("# TYPE",))
 		})
 
 		// +kubebuilder:scaffold:e2e-webhooks-checks

testdata/project-v4-multigroup/test/e2e/e2e_test.go

@@ -255,9 +255,8 @@ var _ = Describe("Manager", Ordered, func() {
 
 			By("getting the metrics by checking curl-metrics logs")
 			metricsOutput := getMetricsOutput()
-			Expect(metricsOutput).To(ContainSubstring(
-				"controller_runtime_reconcile_total",
-			))
+			Expect(metricsOutput).NotTo(BeEmpty())
+			Expect(metricsOutput).To(ContainSubstring("# TYPE"))
 		})
 
 		It("should provisioned cert-manager", func() {

testdata/project-v4-with-plugins/test/e2e/e2e_test.go

@@ -255,9 +255,8 @@ var _ = Describe("Manager", Ordered, func() {
 
 			By("getting the metrics by checking curl-metrics logs")
 			metricsOutput := getMetricsOutput()
-			Expect(metricsOutput).To(ContainSubstring(
-				"controller_runtime_reconcile_total",
-			))
+			Expect(metricsOutput).NotTo(BeEmpty())
+			Expect(metricsOutput).To(ContainSubstring("# TYPE"))
 		})
 
 		It("should provisioned cert-manager", func() {

testdata/project-v4/test/e2e/e2e_test.go

@@ -255,9 +255,8 @@ var _ = Describe("Manager", Ordered, func() {
 
 			By("getting the metrics by checking curl-metrics logs")
 			metricsOutput := getMetricsOutput()
-			Expect(metricsOutput).To(ContainSubstring(
-				"controller_runtime_reconcile_total",
-			))
+			Expect(metricsOutput).NotTo(BeEmpty())
+			Expect(metricsOutput).To(ContainSubstring("# TYPE"))
 		})
 
 		It("should provisioned cert-manager", func() {