Merge pull request #3727 from mateusoliveira43/fix/dockerfile-template-syntax

k8s-ci-robot · web-flow · commit 713c2d0d1842 · 2024-01-16T13:04:51.000+01:00
🐛 (go/v4): Standardize 'AS' Keyword Capitalization in Dockerfile for Clarity
diff --git a/docs/book/src/component-config-tutorial/testdata/project/Dockerfile b/docs/book/src/component-config-tutorial/testdata/project/Dockerfile
@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.20 as builder
+FROM golang:1.20 AS builder
 ARG TARGETOS
 ARG TARGETARCH
 
diff --git a/docs/book/src/cronjob-tutorial/testdata/project/Dockerfile b/docs/book/src/cronjob-tutorial/testdata/project/Dockerfile
@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.20 as builder
+FROM golang:1.20 AS builder
 ARG TARGETOS
 ARG TARGETARCH
 
diff --git a/pkg/plugins/golang/v4/scaffolds/internal/templates/dockerfile.go b/pkg/plugins/golang/v4/scaffolds/internal/templates/dockerfile.go
@@ -39,7 +39,7 @@ func (f *Dockerfile) SetTemplateDefaults() error {
 }
 
 const dockerfileTemplate = `# Build the manager binary
-FROM golang:1.20 as builder
+FROM golang:1.20 AS builder
 ARG TARGETOS
 ARG TARGETARCH
 
diff --git a/testdata/project-v4-multigroup-with-deploy-image/Dockerfile b/testdata/project-v4-multigroup-with-deploy-image/Dockerfile
@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.20 as builder
+FROM golang:1.20 AS builder
 ARG TARGETOS
 ARG TARGETARCH
 
diff --git a/testdata/project-v4-multigroup/Dockerfile b/testdata/project-v4-multigroup/Dockerfile
@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.20 as builder
+FROM golang:1.20 AS builder
 ARG TARGETOS
 ARG TARGETARCH
 
diff --git a/testdata/project-v4-with-deploy-image/Dockerfile b/testdata/project-v4-with-deploy-image/Dockerfile
@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.20 as builder
+FROM golang:1.20 AS builder
 ARG TARGETOS
 ARG TARGETARCH
 
diff --git a/testdata/project-v4-with-grafana/Dockerfile b/testdata/project-v4-with-grafana/Dockerfile
@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.20 as builder
+FROM golang:1.20 AS builder
 ARG TARGETOS
 ARG TARGETARCH
 
diff --git a/testdata/project-v4/Dockerfile b/testdata/project-v4/Dockerfile
@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.20 as builder
+FROM golang:1.20 AS builder
 ARG TARGETOS
 ARG TARGETARCH
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ func (f *Dockerfile) SetTemplateDefaults() error {`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	const dockerfileTemplate = `# Build the manager binary
`42`		`-FROM golang:1.20 as builder`
	`42`	`+FROM golang:1.20 AS builder`
`43`	`43`	`ARG TARGETOS`
`44`	`44`	`ARG TARGETARCH`
`45`	`45`