Don't rewrite potentially shared values

justinsb · justinsb · commit 7623c7569b7a · 2019-11-12T00:22:42.000-05:00
Make them constant and use a local var.
diff --git a/pkg/scaffold/v2/webhook/webhook.go b/pkg/scaffold/v2/webhook/webhook.go
@@ -68,14 +68,15 @@ func (a *Webhook) GetInput() (input.Input, error) {
 		a.Path = filepath.Join("api", a.Resource.Version,
 			fmt.Sprintf("%s_webhook.go", strings.ToLower(a.Resource.Kind)))
 	}
+	webhookTemplate := WebhookTemplate
 	if a.Defaulting {
-		WebhookTemplate = WebhookTemplate + DefaultingWebhookTemplate
+		webhookTemplate = webhookTemplate + DefaultingWebhookTemplate
 	}
 	if a.Validating {
-		WebhookTemplate = WebhookTemplate + ValidatingWebhookTemplate
+		webhookTemplate = webhookTemplate + ValidatingWebhookTemplate
 	}
 
-	a.TemplateBody = WebhookTemplate
+	a.TemplateBody = webhookTemplate
 	a.Input.IfExistsAction = input.Error
 	return a.Input, nil
 }
@@ -85,7 +86,7 @@ func (g *Webhook) Validate() error {
 	return g.Resource.Validate()
 }
 
-var (
+const (
 	WebhookTemplate = `{{ .Boilerplate }}
 
 package {{ .Resource.Version }}

Original file line number	Diff line number	Diff line change
`@@ -68,14 +68,15 @@ func (a *Webhook) GetInput() (input.Input, error) {`
`68`	`68`	`a.Path = filepath.Join("api", a.Resource.Version,`
`69`	`69`	`fmt.Sprintf("%s_webhook.go", strings.ToLower(a.Resource.Kind)))`
`70`	`70`	`}`
	`71`	`+ webhookTemplate := WebhookTemplate`
`71`	`72`	`if a.Defaulting {`
`72`		`- WebhookTemplate = WebhookTemplate + DefaultingWebhookTemplate`
	`73`	`+ webhookTemplate = webhookTemplate + DefaultingWebhookTemplate`
`73`	`74`	`}`
`74`	`75`	`if a.Validating {`
`75`		`- WebhookTemplate = WebhookTemplate + ValidatingWebhookTemplate`
	`76`	`+ webhookTemplate = webhookTemplate + ValidatingWebhookTemplate`
`76`	`77`	`}`
`77`	`78`
`78`		`- a.TemplateBody = WebhookTemplate`
	`79`	`+ a.TemplateBody = webhookTemplate`
`79`	`80`	`a.Input.IfExistsAction = input.Error`
`80`	`81`	`return a.Input, nil`
`81`	`82`	`}`
`@@ -85,7 +86,7 @@ func (g *Webhook) Validate() error {`
`85`	`86`	`return g.Resource.Validate()`
`86`	`87`	`}`
`87`	`88`
`88`		`-var (`
	`89`	`+const (`
`89`	`90`	WebhookTemplate = `{{ .Boilerplate }}
`90`	`91`
`91`	`92`	`package {{ .Resource.Version }}`