Skip to content

Commit 8284311

Browse files
[fix: go/v3, go/v4] Remove stale imports
This PR removes the stale import: "pkg/envtest/printer" that is not needed after migrating to ginko/v2. Controller-runtime v0.14.0+ has migrated to use ginko/v2 and thereby removed "printer" package. The imports were still being scaffolded though not used in the codebase. Signed-off-by: Varsha Prasad Narsing <[email protected]>
1 parent 014e08c commit 8284311

File tree

4 files changed

+0
-4
lines changed

4 files changed

+0
-4
lines changed

pkg/plugins/golang/v3/scaffolds/internal/templates/api/webhook_suitetest.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@ import (
149149
ctrl "sigs.k8s.io/controller-runtime"
150150
"sigs.k8s.io/controller-runtime/pkg/client"
151151
"sigs.k8s.io/controller-runtime/pkg/envtest"
152-
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
153152
logf "sigs.k8s.io/controller-runtime/pkg/log"
154153
"sigs.k8s.io/controller-runtime/pkg/log/zap"
155154
)

pkg/plugins/golang/v3/scaffolds/internal/templates/controllers/controller_suitetest.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ import (
138138
"k8s.io/client-go/rest"
139139
"sigs.k8s.io/controller-runtime/pkg/client"
140140
"sigs.k8s.io/controller-runtime/pkg/envtest"
141-
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
142141
logf "sigs.k8s.io/controller-runtime/pkg/log"
143142
"sigs.k8s.io/controller-runtime/pkg/log/zap"
144143
%s

pkg/plugins/golang/v4/scaffolds/internal/templates/api/webhook_suitetest.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ import (
146146
ctrl "sigs.k8s.io/controller-runtime"
147147
"sigs.k8s.io/controller-runtime/pkg/client"
148148
"sigs.k8s.io/controller-runtime/pkg/envtest"
149-
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
150149
logf "sigs.k8s.io/controller-runtime/pkg/log"
151150
"sigs.k8s.io/controller-runtime/pkg/log/zap"
152151
)

pkg/plugins/golang/v4/scaffolds/internal/templates/controllers/controller_suitetest.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ import (
140140
"k8s.io/client-go/rest"
141141
"sigs.k8s.io/controller-runtime/pkg/client"
142142
"sigs.k8s.io/controller-runtime/pkg/envtest"
143-
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
144143
logf "sigs.k8s.io/controller-runtime/pkg/log"
145144
"sigs.k8s.io/controller-runtime/pkg/log/zap"
146145
%s

0 commit comments

Comments
 (0)