✨ Upgrade golangci from 1.54 to 1.57 (#3846)

* Upgrade golangci from 1.54 to 1.57
* Fix lint issues after upgrade by:

a) Ensure that in all places we are ignoring the exception equally

```go
         // nolint:revive
	. "github.com/onsi/ginkgo/v2"
	// nolint:revive
	. "github.com/onsi/gomega"
```

b) Ensure that we use `_` for args not explicit called in the funcs. Example

```go
PreRunE: func(_ *cobra.Command, _ []string) error {
```

Author: camilamacedo86

.github/workflows/lint-sample.yml

@@ -40,14 +40,14 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v4
         with:
-          version: v1.54
+          version: v1.57
           working-directory: testdata/project-v4-with-deploy-image
           args: --config .golangci.yml ./...
           skip-cache: true  # first lint action will handle
       - name: Run linter
         uses: golangci/golangci-lint-action@v4
         with:
-          version: v1.54
+          version: v1.57
           working-directory: testdata/project-v4-multigroup-with-deploy-image
           args: --config .golangci.yml ./...
           skip-cache: true  # first lint action will handle

.github/workflows/lint.yml

@@ -21,7 +21,7 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v4
         with:
-          version: v1.54
+          version: v1.57
 
   yamllint:
     runs-on: ubuntu-latest

Makefile

@@ -104,7 +104,7 @@ GOLANGCI_LINT = $(shell pwd)/bin/golangci-lint
 golangci-lint:
 	@[ -f $(GOLANGCI_LINT) ] || { \
 	set -e ;\
-	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell dirname $(GOLANGCI_LINT)) v1.54.2 ;\
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell dirname $(GOLANGCI_LINT)) v1.57.2 ;\
 	}
 
 .PHONY: apidiff

docs/book/src/component-config-tutorial/testdata/project/Makefile

@@ -161,7 +161,7 @@ GOLANGCI_LINT = $(LOCALBIN)/golangci-lint-$(GOLANGCI_LINT_VERSION)
 KUSTOMIZE_VERSION ?= v5.3.0
 CONTROLLER_TOOLS_VERSION ?= v0.14.0
 ENVTEST_VERSION ?= release-0.17
-GOLANGCI_LINT_VERSION ?= v1.54.2
+GOLANGCI_LINT_VERSION ?= v1.57.2
 
 .PHONY: kustomize
 kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary.

docs/book/src/component-config-tutorial/testdata/project/test/e2e/e2e_suite_test.go

@@ -20,7 +20,9 @@ import (
 	"fmt"
 	"testing"
 
+	// nolint:revive
 	. "github.com/onsi/ginkgo/v2"
+	// nolint:revive
 	. "github.com/onsi/gomega"
 )
 

docs/book/src/component-config-tutorial/testdata/project/test/e2e/e2e_test.go

@@ -21,7 +21,9 @@ import (
 	"os/exec"
 	"time"
 
+	// nolint:revive
 	. "github.com/onsi/ginkgo/v2"
+	// nolint:revive
 	. "github.com/onsi/gomega"
 
 	"tutorial.kubebuilder.io/project/test/utils"

docs/book/src/component-config-tutorial/testdata/project/test/utils/utils.go

@@ -22,6 +22,7 @@ import (
 	"os/exec"
 	"strings"
 
+	// nolint:revive
 	. "github.com/onsi/ginkgo/v2" //nolint:golint,revive
 )
 

docs/book/src/cronjob-tutorial/testdata/project/Makefile

@@ -161,7 +161,7 @@ GOLANGCI_LINT = $(LOCALBIN)/golangci-lint-$(GOLANGCI_LINT_VERSION)
 KUSTOMIZE_VERSION ?= v5.3.0
 CONTROLLER_TOOLS_VERSION ?= v0.14.0
 ENVTEST_VERSION ?= release-0.17
-GOLANGCI_LINT_VERSION ?= v1.54.2
+GOLANGCI_LINT_VERSION ?= v1.57.2
 
 .PHONY: kustomize
 kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary.

docs/book/src/cronjob-tutorial/testdata/project/api/v1/cronjob_webhook_test.go

@@ -17,6 +17,7 @@ limitations under the License.
 package v1
 
 import (
+	// nolint:revive
 	. "github.com/onsi/ginkgo/v2"
 )
 

docs/book/src/cronjob-tutorial/testdata/project/api/v1/webhook_suite_test.go

@@ -26,10 +26,12 @@ import (
 	"testing"
 	"time"
 
+	// nolint:revive
 	. "github.com/onsi/ginkgo/v2"
+	// nolint:revive
 	. "github.com/onsi/gomega"
-
 	admissionv1 "k8s.io/api/admission/v1"
+
 	//+kubebuilder:scaffold:imports
 	apimachineryruntime "k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/rest"