Skip to content

Commit ae06fc8

Browse files
authored
Merge pull request #1168 from camilamacedo86/ci
Fix CI
2 parents 9eeec12 + fe52a52 commit ae06fc8

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ Kubernetes projects require that you sign a Contributor License Agreement (CLA)
77
Please see https://git.k8s.io/community/CLA.md for more info.
88

99
## Prerequisites
10-
- [go](https://golang.org/dl/) version v1.12+.
11-
- [dep](https://github.com/golang/dep) dep v0.5.1+ < v.0.5.4
10+
- [go](https://golang.org/dl/) version v1.13+.
11+
- [dep](https://github.com/golang/dep) dep v0.5+
1212
- [docker](https://docs.docker.com/install/) version 17.03+.
1313
- [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/) version v1.11.3+.
1414
- [kustomize](https://sigs.k8s.io/kustomize/docs/INSTALL.md) v3.1.0+
@@ -33,7 +33,7 @@ $ git clone [email protected]:<user>/kubebuilder.git $GOPATH/src/sigs.k8s.io/kubebu
3333
1. Build the project by using the command `make build`
3434
1. Run the tests by using the command `make test`
3535
1. Run the command `make install` to create a bin with the source code
36-
1. Run the script `./generated_golden.sh` to update/generate the mock data used in the e2e test in `$GOPATH/src/sigs.k8s.io/kubebuilder/testdata/`
36+
1. Run the script `make generate` to update/generate the mock data used in the e2e test in `$GOPATH/src/sigs.k8s.io/kubebuilder/testdata/`
3737

3838
## Community, discussion and support
3939

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ install: ## Build and install the binary with the current source code. Use it to
4545

4646
.PHONY: generate
4747
generate: ## Update/generate all mock data. You should run this commands to update the mock data after your changes.
48-
make generate-vendor
4948
make generate-setup
5049
make generate-testdata
50+
go mod tidy
5151

5252
.PHONY: generate-testdata
5353
generate-testdata: ## Update/generate the testdata in $GOPATH/src/sigs.k8s.io/kubebuilder

pkg/scaffold/v2/dockerfile.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func (c *Dockerfile) GetInput() (input.Input, error) {
3737
}
3838

3939
var dockerfileTemplate = `# Build the manager binary
40-
FROM golang:1.12.5 as builder
40+
FROM golang:1.13 as builder
4141
4242
WORKDIR /workspace
4343
# Copy the Go Modules manifests

testdata/project-v2/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Build the manager binary
2-
FROM golang:1.12.5 as builder
2+
FROM golang:1.13 as builder
33

44
WORKDIR /workspace
55
# Copy the Go Modules manifests

0 commit comments

Comments
 (0)