Merge pull request #4956 from mayuka-c/issue-4925-part3

🌱 (CLI): Add unit tests for plugin utils

Author: k8s-ci-robot

pkg/plugin/util/stdin.go

@@ -27,7 +27,7 @@ import (
 // true for "y" and false for "n"
 func YesNo(reader *bufio.Reader) bool {
 	for {
-		text := readstdin(reader)
+		text := readStdin(reader)
 		switch text {
 		case "y", "yes":
 			return true
@@ -39,9 +39,9 @@ func YesNo(reader *bufio.Reader) bool {
 	}
 }
 
-// Readstdin reads a line from stdin trimming spaces, and returns the value.
+// readStdin reads a line from stdin trimming spaces, and returns the value.
 // log.Fatal's if there is an error.
-func readstdin(reader *bufio.Reader) string {
+func readStdin(reader *bufio.Reader) string {
 	text, err := reader.ReadString('\n')
 	if err != nil {
 		log.Fatalf("Error when reading input: %v", err)

pkg/plugin/util/stdin_test.go

@@ -0,0 +1,70 @@
+/*
+Copyright 2025 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package util
+
+import (
+	"bufio"
+	"os"
+	"strings"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+var _ = Describe("stdin", func() {
+	It("returns true for 'y'", func() {
+		reader := bufio.NewReader(strings.NewReader("y\n"))
+		Expect(YesNo(reader)).To(BeTrue())
+	})
+
+	It("returns true for 'yes'", func() {
+		reader := bufio.NewReader(strings.NewReader("yes\n"))
+		Expect(YesNo(reader)).To(BeTrue())
+	})
+
+	It("returns false for 'n'", func() {
+		reader := bufio.NewReader(strings.NewReader("n\n"))
+		Expect(YesNo(reader)).To(BeFalse())
+	})
+
+	It("returns false for 'no'", func() {
+		reader := bufio.NewReader(strings.NewReader("no\n"))
+		Expect(YesNo(reader)).To(BeFalse())
+	})
+
+	It("prompts again on invalid input", func() {
+		// "maybe" is invalid, then "y" is valid
+		input := "maybe\ny\n"
+		reader := bufio.NewReader(strings.NewReader(input))
+
+		// Capture stdout to check for prompt
+		oldStdout := os.Stdout
+		_, w, _ := os.Pipe()
+		os.Stdout = w
+
+		// Call YesNo directly (no goroutine needed)
+		Expect(YesNo(reader)).To(BeTrue())
+
+		Expect(w.Close()).NotTo(HaveOccurred())
+		os.Stdout = oldStdout
+	})
+
+	It("trims spaces and works", func() {
+		reader := bufio.NewReader(strings.NewReader("  yes  \n"))
+		Expect(YesNo(reader)).To(BeTrue())
+	})
+})