fix lint issue Error return value of fmt.Fprintln and fmt.Fprintf is not checked (errcheck)

camilamacedo86 · camilamacedo86 · commit bf42d5068359 · 2024-07-19T09:16:31.000+01:00
diff --git a/docs/book/src/cronjob-tutorial/testdata/project/test/e2e/e2e_suite_test.go b/docs/book/src/cronjob-tutorial/testdata/project/test/e2e/e2e_suite_test.go
@@ -27,6 +27,6 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting project suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting project suite\n")
 	RunSpecs(t, "e2e suite")
 }
diff --git a/docs/book/src/cronjob-tutorial/testdata/project/test/utils/utils.go b/docs/book/src/cronjob-tutorial/testdata/project/test/utils/utils.go
@@ -35,7 +35,7 @@ const (
 )
 
 func warnError(err error) {
-	fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
+	_, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
 }
 
 // InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.
@@ -52,12 +52,12 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
 	cmd.Dir = dir
 
 	if err := os.Chdir(cmd.Dir); err != nil {
-		fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
+		_, _ = fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
 	}
 
 	cmd.Env = append(os.Environ(), "GO111MODULE=on")
 	command := strings.Join(cmd.Args, " ")
-	fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
+	_, _ = fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
 	output, err := cmd.CombinedOutput()
 	if err != nil {
 		return output, fmt.Errorf("%s failed with error: (%v) %s", command, err, string(output))
diff --git a/docs/book/src/getting-started/testdata/project/test/e2e/e2e_suite_test.go b/docs/book/src/getting-started/testdata/project/test/e2e/e2e_suite_test.go
@@ -27,6 +27,6 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting project suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting project suite\n")
 	RunSpecs(t, "e2e suite")
 }
diff --git a/docs/book/src/getting-started/testdata/project/test/utils/utils.go b/docs/book/src/getting-started/testdata/project/test/utils/utils.go
@@ -35,7 +35,7 @@ const (
 )
 
 func warnError(err error) {
-	fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
+	_, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
 }
 
 // InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.
@@ -52,12 +52,12 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
 	cmd.Dir = dir
 
 	if err := os.Chdir(cmd.Dir); err != nil {
-		fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
+		_, _ = fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
 	}
 
 	cmd.Env = append(os.Environ(), "GO111MODULE=on")
 	command := strings.Join(cmd.Args, " ")
-	fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
+	_, _ = fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
 	output, err := cmd.CombinedOutput()
 	if err != nil {
 		return output, fmt.Errorf("%s failed with error: (%v) %s", command, err, string(output))
diff --git a/docs/book/src/multiversion-tutorial/testdata/project/test/e2e/e2e_suite_test.go b/docs/book/src/multiversion-tutorial/testdata/project/test/e2e/e2e_suite_test.go
@@ -27,6 +27,6 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting project suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting project suite\n")
 	RunSpecs(t, "e2e suite")
 }
diff --git a/docs/book/src/multiversion-tutorial/testdata/project/test/utils/utils.go b/docs/book/src/multiversion-tutorial/testdata/project/test/utils/utils.go
@@ -35,7 +35,7 @@ const (
 )
 
 func warnError(err error) {
-	fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
+	_, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
 }
 
 // InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.
@@ -52,12 +52,12 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
 	cmd.Dir = dir
 
 	if err := os.Chdir(cmd.Dir); err != nil {
-		fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
+		_, _ = fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
 	}
 
 	cmd.Env = append(os.Environ(), "GO111MODULE=on")
 	command := strings.Join(cmd.Args, " ")
-	fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
+	_, _ = fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
 	output, err := cmd.CombinedOutput()
 	if err != nil {
 		return output, fmt.Errorf("%s failed with error: (%v) %s", command, err, string(output))
diff --git a/docs/book/src/reference/envtest.md b/docs/book/src/reference/envtest.md
@@ -248,7 +248,7 @@ const (
 )
 
 func warnError(err error) {
-	fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
+	_, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
 }
 
 // InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.
diff --git a/docs/book/utils/markerdocs/html.go b/docs/book/utils/markerdocs/html.go
@@ -77,7 +77,8 @@ func (t Tag) WriteHTML(w io.Writer) error {
 	if t.Attrs != nil {
 		attrsOut = t.Attrs.ToAttrs()
 	}
-	if _, err := fmt.Fprintf(w, "<%s %s>", t.Name, attrsOut); err != nil {
+	if _, err := fmt.Fprintf((w, "<%s %s>", t.Name, attrsOut)
+	err != nil{
 		return err
 	}
 
@@ -87,7 +88,8 @@ func (t Tag) WriteHTML(w io.Writer) error {
 		}
 	}
 
-	if _, err := fmt.Fprintf(w, "</%s>", t.Name); err != nil {
+	if _, err := fmt.Fprintf((w, "</%s>", t.Name)
+	err != nil{
 		return err
 	}
 
diff --git a/docs/book/utils/markerdocs/main.go b/docs/book/utils/markerdocs/main.go
@@ -164,7 +164,7 @@ func (p MarkerDocs) Process(input *plugin.Input) error {
 		content := new(strings.Builder)
 
 		// NB(directxman12): wrap this in a div to prevent the markdown processor from inserting extra paragraphs
-		_, err := fmt.Fprintf(content, "<div><input checked type=\"checkbox\" class=\"markers-summarize\" id=\"markers-summarize-%[1]s\"></input><label class=\"markers-summarize\" for=\"markers-summarize-%[1]s\">Show Detailed Argument Help</label><dl class=\"markers\">", categoryAlias)
+		_, err := fmt.Fprintf((content, "<div><input checked type=\"checkbox\" class=\"markers-summarize\" id=\"markers-summarize-%[1]s\"></input><label class=\"markers-summarize\" for=\"markers-summarize-%[1]s\">Show Detailed Argument Help</label><dl class=\"markers\">", categoryAlias)
 		if err != nil {
 			return "", fmt.Errorf("unable to render marker documentation summary: %v", err)
 		}
@@ -176,7 +176,8 @@ func (p MarkerDocs) Process(input *plugin.Input) error {
 			}
 		}
 
-		if _, err = fmt.Fprintf(content, "</dl></div>"); err != nil {
+		if _, err = _, _ = fmt.Fprintf(content, "</dl></div>")
+		err != nil{
 			return "", fmt.Errorf("unable to render marker documentation: %v", err)
 		}
 
diff --git a/pkg/cli/cli.go b/pkg/cli/cli.go
@@ -444,7 +444,7 @@ func (c *CLI) addExtraCommands() error {
 func (c CLI) printDeprecationWarnings() {
 	for _, p := range c.resolvedPlugins {
 		if p != nil && p.(plugin.Deprecated) != nil && len(p.(plugin.Deprecated).DeprecationWarning()) > 0 {
-			fmt.Fprintf(os.Stderr, noticeColor, fmt.Sprintf(deprecationFmt, p.(plugin.Deprecated).DeprecationWarning()))
+			_, _ = fmt.Fprintf(os.Stderr, noticeColor, fmt.Sprintf(deprecationFmt, p.(plugin.Deprecated).DeprecationWarning()))
 		}
 	}
 }
diff --git a/pkg/plugins/golang/v4/scaffolds/internal/templates/test/e2e/suite.go b/pkg/plugins/golang/v4/scaffolds/internal/templates/test/e2e/suite.go
@@ -53,7 +53,7 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting {{ .ProjectName }} suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting {{ .ProjectName }} suite\n")
 	RunSpecs(t, "e2e suite")
 }
 `
diff --git a/pkg/plugins/golang/v4/scaffolds/internal/templates/test/utils/utils.go b/pkg/plugins/golang/v4/scaffolds/internal/templates/test/utils/utils.go
@@ -60,7 +60,7 @@ const (
 )
 
 func warnError(err error) {
-	fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
+	_, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
 }
 
 // InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.
@@ -77,12 +77,12 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
 	cmd.Dir = dir
 
 	if err := os.Chdir(cmd.Dir); err != nil {
-		fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
+		_, _ = fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
 	}
 
 	cmd.Env = append(os.Environ(), "GO111MODULE=on")
 	command := strings.Join(cmd.Args, " ")
-	fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
+	_, _ = fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
 	output, err := cmd.CombinedOutput()
 	if err != nil {
 		return output, fmt.Errorf("%s failed with error: (%v) %s", command, err, string(output))
diff --git a/pkg/plugins/optional/grafana/v1alpha/scaffolds/edit.go b/pkg/plugins/optional/grafana/v1alpha/scaffolds/edit.go
@@ -179,7 +179,7 @@ func (s *editScaffolder) Scaffold() error {
 	if err == nil && len(configItems) > 0 {
 		templatesBuilder = append(templatesBuilder, &templates.CustomMetricsDashManifest{Items: configItems})
 	} else if err != nil {
-		fmt.Fprintf(os.Stderr, "Error on scaffolding manifest for custom metris:\n%v", err)
+		_, _ = fmt.Fprintf(os.Stderr, "Error on scaffolding manifest for custom metris:\n%v", err)
 	}
 
 	return scaffold.Execute(templatesBuilder...)
diff --git a/test/e2e/alphagenerate/e2e_suite_test.go b/test/e2e/alphagenerate/e2e_suite_test.go
@@ -27,6 +27,6 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting kubebuilder suite test for the alpha command generate\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting kubebuilder suite test for the alpha command generate\n")
 	RunSpecs(t, "Kubebuilder alpha generate suite")
 }
diff --git a/test/e2e/deployimage/e2e_suite_test.go b/test/e2e/deployimage/e2e_suite_test.go
@@ -27,6 +27,6 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting kubebuilder suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting kubebuilder suite\n")
 	RunSpecs(t, "Kubebuilder e2e suite")
 }
diff --git a/test/e2e/deployimage/plugin_cluster_test.go b/test/e2e/deployimage/plugin_cluster_test.go
@@ -133,7 +133,7 @@ func Run(kbc *utils.TestContext) {
 	defer func() {
 		out, err := kbc.Kubectl.CommandInNamespace("describe", "all")
 		ExpectWithOffset(1, err).NotTo(HaveOccurred())
-		fmt.Fprintln(GinkgoWriter, out)
+		_, _ = fmt.Fprintln(GinkgoWriter, out)
 	}()
 	EventuallyWithOffset(1, verifyControllerUp, time.Minute, time.Second).Should(Succeed())
 	By("creating an instance of the CR")
diff --git a/test/e2e/externalplugin/e2e_suite_test.go b/test/e2e/externalplugin/e2e_suite_test.go
@@ -27,6 +27,6 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting sample external plugin kubebuilder suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting sample external plugin kubebuilder suite\n")
 	RunSpecs(t, "Kubebuilder sample external plugin e2e suite")
 }
diff --git a/test/e2e/grafana/e2e_suite_test.go b/test/e2e/grafana/e2e_suite_test.go
@@ -27,6 +27,6 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting grafana plugin kubebuilder suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting grafana plugin kubebuilder suite\n")
 	RunSpecs(t, "Kubebuilder grafana plugin e2e suite")
 }
diff --git a/test/e2e/utils/test_context.go b/test/e2e/utils/test_context.go
@@ -98,13 +98,13 @@ func NewTestContext(binaryName string, env ...string) (*TestContext, error) {
 }
 
 func warnError(err error) {
-	fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
+	_, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
 }
 
 // Prepare prepares the test environment.
 func (t *TestContext) Prepare() error {
 	// Remove tools used by projects in the environment so the correct version is downloaded for each test.
-	fmt.Fprintln(GinkgoWriter, "cleaning up tools")
+	_, _ = fmt.Fprintln(GinkgoWriter, "cleaning up tools")
 	for _, toolName := range []string{"controller-gen", "kustomize"} {
 		if toolPath, err := exec.LookPath(toolName); err == nil {
 			if err := os.RemoveAll(toolPath); err != nil {
@@ -113,7 +113,7 @@ func (t *TestContext) Prepare() error {
 		}
 	}
 
-	fmt.Fprintf(GinkgoWriter, "preparing testing directory: %s\n", t.Dir)
+	_, _ = fmt.Fprintf(GinkgoWriter, "preparing testing directory: %s\n", t.Dir)
 	return os.MkdirAll(t.Dir, 0o755)
 }
 
@@ -306,7 +306,7 @@ func (cc *CmdContext) Run(cmd *exec.Cmd) ([]byte, error) {
 	cmd.Env = append(os.Environ(), cc.Env...)
 	cmd.Stdin = cc.Stdin
 	command := strings.Join(cmd.Args, " ")
-	fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
+	_, _ = fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
 	output, err := cmd.CombinedOutput()
 	if err != nil {
 		return output, fmt.Errorf("%s failed with error: (%v) %s", command, err, string(output))
diff --git a/test/e2e/v4/e2e_suite_test.go b/test/e2e/v4/e2e_suite_test.go
@@ -30,7 +30,7 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting kubebuilder suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting kubebuilder suite\n")
 	RunSpecs(t, "Kubebuilder e2e suite")
 }
 
diff --git a/test/e2e/v4/plugin_cluster_test.go b/test/e2e/v4/plugin_cluster_test.go
@@ -289,7 +289,7 @@ func getControllerName(kbc *utils.TestContext) string {
 	defer func() {
 		out, err := kbc.Kubectl.CommandInNamespace("describe", "all")
 		ExpectWithOffset(1, err).NotTo(HaveOccurred())
-		fmt.Fprintln(GinkgoWriter, out)
+		_, _ = fmt.Fprintln(GinkgoWriter, out)
 	}()
 	EventuallyWithOffset(1, verifyControllerUp, time.Minute, time.Second).Should(Succeed())
 	return controllerPodName
diff --git a/testdata/project-v4-multigroup-with-deploy-image/test/e2e/e2e_suite_test.go b/testdata/project-v4-multigroup-with-deploy-image/test/e2e/e2e_suite_test.go
@@ -27,6 +27,6 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting project-v4-multigroup-with-deploy-image suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting project-v4-multigroup-with-deploy-image suite\n")
 	RunSpecs(t, "e2e suite")
 }
diff --git a/testdata/project-v4-multigroup-with-deploy-image/test/utils/utils.go b/testdata/project-v4-multigroup-with-deploy-image/test/utils/utils.go
@@ -35,7 +35,7 @@ const (
 )
 
 func warnError(err error) {
-	fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
+	_, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
 }
 
 // InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.
@@ -52,12 +52,12 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
 	cmd.Dir = dir
 
 	if err := os.Chdir(cmd.Dir); err != nil {
-		fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
+		_, _ = fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
 	}
 
 	cmd.Env = append(os.Environ(), "GO111MODULE=on")
 	command := strings.Join(cmd.Args, " ")
-	fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
+	_, _ = fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
 	output, err := cmd.CombinedOutput()
 	if err != nil {
 		return output, fmt.Errorf("%s failed with error: (%v) %s", command, err, string(output))
diff --git a/testdata/project-v4-multigroup/test/e2e/e2e_suite_test.go b/testdata/project-v4-multigroup/test/e2e/e2e_suite_test.go
@@ -27,6 +27,6 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting project-v4-multigroup suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting project-v4-multigroup suite\n")
 	RunSpecs(t, "e2e suite")
 }
diff --git a/testdata/project-v4-multigroup/test/utils/utils.go b/testdata/project-v4-multigroup/test/utils/utils.go
@@ -35,7 +35,7 @@ const (
 )
 
 func warnError(err error) {
-	fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
+	_, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
 }
 
 // InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.
@@ -52,12 +52,12 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
 	cmd.Dir = dir
 
 	if err := os.Chdir(cmd.Dir); err != nil {
-		fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
+		_, _ = fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
 	}
 
 	cmd.Env = append(os.Environ(), "GO111MODULE=on")
 	command := strings.Join(cmd.Args, " ")
-	fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
+	_, _ = fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
 	output, err := cmd.CombinedOutput()
 	if err != nil {
 		return output, fmt.Errorf("%s failed with error: (%v) %s", command, err, string(output))
diff --git a/testdata/project-v4-with-deploy-image/test/e2e/e2e_suite_test.go b/testdata/project-v4-with-deploy-image/test/e2e/e2e_suite_test.go
@@ -27,6 +27,6 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting project-v4-with-deploy-image suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting project-v4-with-deploy-image suite\n")
 	RunSpecs(t, "e2e suite")
 }
diff --git a/testdata/project-v4-with-deploy-image/test/utils/utils.go b/testdata/project-v4-with-deploy-image/test/utils/utils.go
@@ -35,7 +35,7 @@ const (
 )
 
 func warnError(err error) {
-	fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
+	_, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
 }
 
 // InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.
@@ -52,12 +52,12 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
 	cmd.Dir = dir
 
 	if err := os.Chdir(cmd.Dir); err != nil {
-		fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
+		_, _ = fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
 	}
 
 	cmd.Env = append(os.Environ(), "GO111MODULE=on")
 	command := strings.Join(cmd.Args, " ")
-	fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
+	_, _ = fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
 	output, err := cmd.CombinedOutput()
 	if err != nil {
 		return output, fmt.Errorf("%s failed with error: (%v) %s", command, err, string(output))
diff --git a/testdata/project-v4-with-grafana/test/e2e/e2e_suite_test.go b/testdata/project-v4-with-grafana/test/e2e/e2e_suite_test.go
@@ -27,6 +27,6 @@ import (
 // Run e2e tests using the Ginkgo runner.
 func TestE2E(t *testing.T) {
 	RegisterFailHandler(Fail)
-	fmt.Fprintf(GinkgoWriter, "Starting project-v4-with-grafana suite\n")
+	_, _ = fmt.Fprintf(GinkgoWriter, "Starting project-v4-with-grafana suite\n")
 	RunSpecs(t, "e2e suite")
 }
diff --git a/testdata/project-v4-with-grafana/test/utils/utils.go b/testdata/project-v4-with-grafana/test/utils/utils.go
diff --git a/testdata/project-v4/test/e2e/e2e_suite_test.go b/testdata/project-v4/test/e2e/e2e_suite_test.go
diff --git a/testdata/project-v4/test/utils/utils.go b/testdata/project-v4/test/utils/utils.go

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,6 @@ import (`
`27`	`27`	`// Run e2e tests using the Ginkgo runner.`
`28`	`28`	`func TestE2E(t *testing.T) {`
`29`	`29`	`RegisterFailHandler(Fail)`
`30`		`- fmt.Fprintf(GinkgoWriter, "Starting project suite\n")`
	`30`	`+ _, _ = fmt.Fprintf(GinkgoWriter, "Starting project suite\n")`
`31`	`31`	`RunSpecs(t, "e2e suite")`
`32`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ const (`
`35`	`35`	`)`
`36`	`36`
`37`	`37`	`func warnError(err error) {`
`38`		`- fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)`
	`38`	`+ _, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`// InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.`
`@@ -52,12 +52,12 @@ func Run(cmd *exec.Cmd) ([]byte, error) {`
`52`	`52`	`cmd.Dir = dir`
`53`	`53`
`54`	`54`	`if err := os.Chdir(cmd.Dir); err != nil {`
`55`		`- fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)`
	`55`	`+ _, _ = fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`cmd.Env = append(os.Environ(), "GO111MODULE=on")`
`59`	`59`	`command := strings.Join(cmd.Args, " ")`
`60`		`- fmt.Fprintf(GinkgoWriter, "running: %s\n", command)`
	`60`	`+ _, _ = fmt.Fprintf(GinkgoWriter, "running: %s\n", command)`
`61`	`61`	`output, err := cmd.CombinedOutput()`
`62`	`62`	`if err != nil {`
`63`	`63`	`return output, fmt.Errorf("%s failed with error: (%v) %s", command, err, string(output))`
Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ const (`
`248`	`248`	`)`
`249`	`249`
`250`	`250`	`func warnError(err error) {`
`251`		`- fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)`
	`251`	`+ _, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)`
`252`	`252`	`}`
`253`	`253`
`254`	`254`	`// InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,8 @@ func (t Tag) WriteHTML(w io.Writer) error {`
`77`	`77`	`if t.Attrs != nil {`
`78`	`78`	`attrsOut = t.Attrs.ToAttrs()`
`79`	`79`	`}`
`80`		`- if _, err := fmt.Fprintf(w, "<%s %s>", t.Name, attrsOut); err != nil {`
	`80`	`+ if _, err := fmt.Fprintf((w, "<%s %s>", t.Name, attrsOut)`
	`81`	`+ err != nil{`
`81`	`82`	`return err`
`82`	`83`	`}`
`83`	`84`
`@@ -87,7 +88,8 @@ func (t Tag) WriteHTML(w io.Writer) error {`
`87`	`88`	`}`
`88`	`89`	`}`
`89`	`90`
`90`		`- if _, err := fmt.Fprintf(w, "</%s>", t.Name); err != nil {`
	`91`	`+ if _, err := fmt.Fprintf((w, "</%s>", t.Name)`
	`92`	`+ err != nil{`
`91`	`93`	`return err`
`92`	`94`	`}`
`93`	`95`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ func (p MarkerDocs) Process(input *plugin.Input) error {`
`164`	`164`	`content := new(strings.Builder)`
`165`	`165`
`166`	`166`	`// NB(directxman12): wrap this in a div to prevent the markdown processor from inserting extra paragraphs`
`167`		`- _, err := fmt.Fprintf(content, "<div><input checked type=\"checkbox\" class=\"markers-summarize\" id=\"markers-summarize-%[1]s\"></input><label class=\"markers-summarize\" for=\"markers-summarize-%[1]s\">Show Detailed Argument Help</label><dl class=\"markers\">", categoryAlias)`
	`167`	`+ _, err := fmt.Fprintf((content, "<div><input checked type=\"checkbox\" class=\"markers-summarize\" id=\"markers-summarize-%[1]s\"></input><label class=\"markers-summarize\" for=\"markers-summarize-%[1]s\">Show Detailed Argument Help</label><dl class=\"markers\">", categoryAlias)`
`168`	`168`	`if err != nil {`
`169`	`169`	`return "", fmt.Errorf("unable to render marker documentation summary: %v", err)`
`170`	`170`	`}`
`@@ -176,7 +176,8 @@ func (p MarkerDocs) Process(input *plugin.Input) error {`
`176`	`176`	`}`
`177`	`177`	`}`
`178`	`178`
`179`		`- if _, err = fmt.Fprintf(content, "</dl></div>"); err != nil {`
	`179`	`+ if _, err = _, _ = fmt.Fprintf(content, "</dl></div>")`
	`180`	`+ err != nil{`
`180`	`181`	`return "", fmt.Errorf("unable to render marker documentation: %v", err)`
`181`	`182`	`}`
`182`	`183`
Original file line number	Diff line number	Diff line change
`@@ -444,7 +444,7 @@ func (c *CLI) addExtraCommands() error {`
`444`	`444`	`func (c CLI) printDeprecationWarnings() {`
`445`	`445`	`for _, p := range c.resolvedPlugins {`
`446`	`446`	`if p != nil && p.(plugin.Deprecated) != nil && len(p.(plugin.Deprecated).DeprecationWarning()) > 0 {`
`447`		`- fmt.Fprintf(os.Stderr, noticeColor, fmt.Sprintf(deprecationFmt, p.(plugin.Deprecated).DeprecationWarning()))`
	`447`	`+ _, _ = fmt.Fprintf(os.Stderr, noticeColor, fmt.Sprintf(deprecationFmt, p.(plugin.Deprecated).DeprecationWarning()))`
`448`	`448`	`}`
`449`	`449`	`}`
`450`	`450`	`}`