Skip to content

Commit c564aed

Browse files
Copilotcamilamacedo86
authored andcommitted
Improve docs layout and collapse code from tutorials
Assisted-by: Cursor
1 parent 83b229b commit c564aed

File tree

27 files changed

+425
-72
lines changed

27 files changed

+425
-72
lines changed

docs/book/book.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,3 @@ command = "./markerdocs.sh"
2121

2222
[context.deploy-preview.environment]
2323
environment = { GO_VERSION = "1.23" }
24-

docs/book/src/cronjob-tutorial/testdata/project/cmd/main.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ func main() {
198198
os.Exit(1)
199199
}
200200

201-
// +kubebuilder:docs-gen:collapse=old stuff
201+
// +kubebuilder:docs-gen:collapse=Remaining code from main.go
202202

203203
if err := (&controller.CronJobReconciler{
204204
Client: mgr.GetClient(),
@@ -239,5 +239,6 @@ func main() {
239239
setupLog.Error(err, "problem running manager")
240240
os.Exit(1)
241241
}
242-
// +kubebuilder:docs-gen:collapse=old stuff
243242
}
243+
244+
// +kubebuilder:docs-gen:collapse=Remaining code from main.go

docs/book/src/cronjob-tutorial/testdata/project/internal/controller/cronjob_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ type Clock interface {
6868
Now() time.Time
6969
}
7070

71-
// +kubebuilder:docs-gen:collapse=Clock
71+
// +kubebuilder:docs-gen:collapse=Clock Code Implementation
7272

7373
// Definitions to manage status conditions
7474
const (

docs/book/src/cronjob-tutorial/testdata/project/internal/controller/cronjob_controller_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,8 @@ var _ = Describe("CronJob controller", func() {
208208

209209
})
210210

211+
// +kubebuilder:docs-gen:collapse=Remaining code from cronjob_controller_test.go
212+
211213
/*
212214
After writing all this code, you can run `go test ./...` in your `controllers/` directory again to run your new test!
213215
*/

docs/book/src/cronjob-tutorial/testdata/project/internal/controller/suite_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,8 @@ var _ = AfterSuite(func() {
170170
Expect(err).NotTo(HaveOccurred())
171171
})
172172

173+
// +kubebuilder:docs-gen:collapse=Remaining code from suite_test.go
174+
173175
/*
174176
Now that you have your controller running on a test cluster and a client ready to perform operations on your CronJob, we can start writing integration tests!
175177
*/

docs/book/src/cronjob-tutorial/testdata/project/internal/webhook/v1/cronjob_webhook.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import (
3636
batchv1 "tutorial.kubebuilder.io/project/api/v1"
3737
)
3838

39-
// +kubebuilder:docs-gen:collapse=Go imports
39+
// +kubebuilder:docs-gen:collapse=Imports
4040

4141
/*
4242
Next, we'll setup a logger for the webhooks.
@@ -279,4 +279,4 @@ func validateCronJobName(cronjob *batchv1.CronJob) *field.Error {
279279
return nil
280280
}
281281

282-
// +kubebuilder:docs-gen:collapse=Validate object name
282+
// +kubebuilder:docs-gen:collapse=validateCronJobName() Code Implementation

docs/book/src/multiversion-tutorial/testdata/project/api/v1/cronjob_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ type CronJobStatus struct {
131131
Conditions []metav1.Condition `json:"conditions,omitempty"`
132132
}
133133

134-
// +kubebuilder:docs-gen:collapse=old stuff
134+
// +kubebuilder:docs-gen:collapse=Remaining code from cronjob_types.go
135135

136136
/*
137137
Since we'll have more than one version, we'll need to mark a storage version.
@@ -183,4 +183,4 @@ func init() {
183183
SchemeBuilder.Register(&CronJob{}, &CronJobList{})
184184
}
185185

186-
// +kubebuilder:docs-gen:collapse=old stuff
186+
// +kubebuilder:docs-gen:collapse=Remaining code from cronjob_types.go

docs/book/src/multiversion-tutorial/testdata/project/api/v2/cronjob_conversion.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,7 @@ func (src *CronJob) ConvertTo(dstRaw conversion.Hub) error {
9090
dst.Status.Active = src.Status.Active
9191
dst.Status.LastScheduleTime = src.Status.LastScheduleTime
9292

93-
// +kubebuilder:docs-gen:collapse=rote conversion
94-
93+
// +kubebuilder:docs-gen:collapse=rest of conversion Code Implementation
9594
return nil
9695
}
9796

@@ -141,7 +140,6 @@ func (dst *CronJob) ConvertFrom(srcRaw conversion.Hub) error {
141140
dst.Status.Active = src.Status.Active
142141
dst.Status.LastScheduleTime = src.Status.LastScheduleTime
143142

144-
// +kubebuilder:docs-gen:collapse=rote conversion
145-
143+
// +kubebuilder:docs-gen:collapse=rest of conversion Code Implementation
146144
return nil
147145
}

docs/book/src/multiversion-tutorial/testdata/project/api/v2/cronjob_types.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,10 @@ type CronJobSpec struct {
8383
// +optional
8484
// +kubebuilder:validation:Minimum=0
8585
FailedJobsHistoryLimit *int32 `json:"failedJobsHistoryLimit,omitempty"`
86-
87-
// +kubebuilder:docs-gen:collapse=The rest of Spec
88-
8986
}
9087

88+
// +kubebuilder:docs-gen:collapse=CronJobSpec Full Code
89+
9190
/*
9291
Next, we'll need to define a type to hold our schedule.
9392
Based on our proposed YAML above, it'll have a field for

docs/book/src/multiversion-tutorial/testdata/project/cmd/main.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,6 @@ func main() {
204204
setupLog.Error(err, "unable to create controller", "controller", "CronJob")
205205
os.Exit(1)
206206
}
207-
// +kubebuilder:docs-gen:collapse=existing setup
208207

209208
/*
210209
Our existing call to SetupWebhookWithManager registers our conversion webhooks with the manager, too.
@@ -225,8 +224,7 @@ func main() {
225224
}
226225
// +kubebuilder:scaffold:builder
227226

228-
/*
229-
*/
227+
// +kubebuilder:docs-gen:collapse=Remaining code from main.go
230228

231229
if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {
232230
setupLog.Error(err, "unable to set up health check")
@@ -242,5 +240,8 @@ func main() {
242240
setupLog.Error(err, "problem running manager")
243241
os.Exit(1)
244242
}
245-
// +kubebuilder:docs-gen:collapse=existing setup
246243
}
244+
245+
// +kubebuilder:docs-gen:collapse=Remaining code from main.go
246+
247+
// +kubebuilder:docs-gen:collapse=Remaining code from main.go

0 commit comments

Comments
 (0)