Skip to content

Commit ccb1127

Browse files
committed
✨ *: Replace 'docker build . -t ${IMG}' with '-t ${IMG} .'
Because folks may have 'docker' aliased to 'podman', and Podman prefers options before positional arguments [1]: $ podman build --help | grep CONTEXT-DIRECTORY podman build [command options] CONTEXT-DIRECTORY | URL Generated with: $ sed -i 's/ . -t \([^ ]*\)/ -t \1 ./' $(git grep -l 'docker.*build.* \. ') $ git checkout HEAD -- docs $ git checkout HEAD -- pkg/plugin/v2 testdata/project-v2* The docs checkout leaves historical docs alone [2,3,4]. The v2 checkouts are because Adrián and Camila consider this minor and not worth fixing in v2 [5]. [1]: containers/podman#2811 [2]: #1817 (comment) [3]: #1817 (comment) [4]: #1817 (comment) [5]: #1817 (comment)
1 parent c158f4f commit ccb1127

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

pkg/plugin/v3/scaffolds/internal/templates/makefile.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ generate: controller-gen
121121
122122
# Build the docker image
123123
docker-build: test
124-
docker build . -t ${IMG}
124+
docker build -t ${IMG} .
125125
126126
# Push the docker image
127127
docker-push:

testdata/project-v3-addon/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ generate: controller-gen
6363

6464
# Build the docker image
6565
docker-build: test
66-
docker build . -t ${IMG}
66+
docker build -t ${IMG} .
6767

6868
# Push the docker image
6969
docker-push:

testdata/project-v3-multigroup/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ generate: controller-gen
6363

6464
# Build the docker image
6565
docker-build: test
66-
docker build . -t ${IMG}
66+
docker build -t ${IMG} .
6767

6868
# Push the docker image
6969
docker-push:

testdata/project-v3/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ generate: controller-gen
6363

6464
# Build the docker image
6565
docker-build: test
66-
docker build . -t ${IMG}
66+
docker build -t ${IMG} .
6767

6868
# Push the docker image
6969
docker-push:

0 commit comments

Comments
 (0)