Skip to content

Commit d46d729

Browse files
committed
Use zap helpers
1 parent 5dc6055 commit d46d729

File tree

7 files changed

+12
-27
lines changed

7 files changed

+12
-27
lines changed

designs/simplified-scaffolding.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ not immediately obvious to these users why the project is structured the
123123
way it is.
124124

125125
Additionally, we scaffold out API "tests" that test that the API server is
126-
able to recieve create requests for the objects, but don't encourage
126+
able to receive create requests for the objects, but don't encourage
127127
modification beyond that. An informal survey seems to indicate that most
128128
users don't actually modify these tests (many repositories continue to
129129
look like
@@ -417,9 +417,7 @@ func init() {
417417
}
418418

419419
func main() {
420-
ctrl.SetLogger(zap.New(func(o *zap.Options) {
421-
o.Development = true
422-
}))
420+
ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
423421

424422
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{Scheme: scheme})
425423
if err != nil {

docs/book/src/cronjob-tutorial/testdata/emptymain.go

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -82,24 +82,21 @@ func main() {
8282
flag.StringVar(&metricsAddr, "metrics-addr", ":8080", "The address the metric endpoint binds to.")
8383
flag.Parse()
8484

85-
ctrl.SetLogger(zap.New(func(o *zap.Options) {
86-
o.Development = true
87-
}))
85+
ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
8886

8987
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{Scheme: scheme, MetricsBindAddress: metricsAddr})
9088
if err != nil {
9189
setupLog.Error(err, "unable to start manager")
9290
os.Exit(1)
9391
}
9492

95-
9693
/*
9794
Note that the Manager can restrict the namespace that all controllers will watch for resources by:
9895
*/
9996

10097
mgr, err = ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
101-
Scheme: scheme,
102-
Namespace: namespace,
98+
Scheme: scheme,
99+
Namespace: namespace,
103100
MetricsBindAddress: metricsAddr,
104101
})
105102

@@ -115,8 +112,8 @@ func main() {
115112
var namespaces []string // List of Namespaces
116113

117114
mgr, err = ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
118-
Scheme: scheme,
119-
NewCache: cache.MultiNamespacedCacheBuilder(namespaces),
115+
Scheme: scheme,
116+
NewCache: cache.MultiNamespacedCacheBuilder(namespaces),
120117
MetricsBindAddress: fmt.Sprintf("%s:%d", metricsHost, metricsPort),
121118
})
122119

docs/book/src/cronjob-tutorial/testdata/project/main.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,7 @@ func main() {
6868
"Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.")
6969
flag.Parse()
7070

71-
ctrl.SetLogger(zap.New(func(o *zap.Options) {
72-
o.Development = true
73-
}))
71+
ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
7472

7573
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
7674
Scheme: scheme,

docs/book/src/multiversion-tutorial/testdata/project/main.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,7 @@ func main() {
6565
"Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.")
6666
flag.Parse()
6767

68-
ctrl.SetLogger(zap.New(func(o *zap.Options) {
69-
o.Development = true
70-
}))
68+
ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
7169

7270
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
7371
Scheme: scheme,

pkg/scaffold/internal/templates/v2/main.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,9 +214,7 @@ func main() {
214214
"Enabling this will ensure there is only one active controller manager.")
215215
flag.Parse()
216216
217-
ctrl.SetLogger(zap.New(func(o *zap.Options) {
218-
o.Development = true
219-
}))
217+
ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
220218
221219
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
222220
Scheme: scheme,

testdata/project-v2-multigroup/main.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,7 @@ func main() {
6767
"Enabling this will ensure there is only one active controller manager.")
6868
flag.Parse()
6969

70-
ctrl.SetLogger(zap.New(func(o *zap.Options) {
71-
o.Development = true
72-
}))
70+
ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
7371

7472
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
7573
Scheme: scheme,

testdata/project-v2/main.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@ func main() {
5252
"Enabling this will ensure there is only one active controller manager.")
5353
flag.Parse()
5454

55-
ctrl.SetLogger(zap.New(func(o *zap.Options) {
56-
o.Development = true
57-
}))
55+
ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
5856

5957
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
6058
Scheme: scheme,

0 commit comments

Comments
 (0)