Skip to content

Commit d904596

Browse files
author
willise
committed
Add more example code of using finalizer
1 parent 0e67e88 commit d904596

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

docs/book/beyond_basics/using_finalizers.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ func (r *Reconciler) Reconcile(request reconcile.Request) (reconcile.Result, err
4646
// The object is being deleted
4747
if containsString(instance.ObjectMeta.Finalizers, myFinalizerName) {
4848
// our finalizer is present, so lets handle our external dependency
49-
err := r.deleteExternalDependency(instance)
50-
if err != nil {
49+
if err := r.deleteExternalDependency(instance); err != nil {
5150
// if fail to delete the external dependency here, return with error
5251
// so that it can be retried
5352
return reconcile.Result{}, err
@@ -59,6 +58,9 @@ func (r *Reconciler) Reconcile(request reconcile.Request) (reconcile.Result, err
5958
return reconcile.Result{Requeue: true}, nil
6059
}
6160
}
61+
62+
// Our finalizer has finished, so the reconciler can do nothing.
63+
return reconcile.Result{}, nil
6264
}
6365
....
6466
....

0 commit comments

Comments
 (0)