Merge pull request #2861 from NikhilSharmaWe/testStatusCond

✨deploy-image/v1-alpha: add check for status conditions added to the custom resource

Author: k8s-ci-robot

pkg/plugins/golang/deploy-image/v1alpha1/scaffolds/internal/templates/controllers/controller-test.go

@@ -63,6 +63,7 @@ import (
 	"context"
 	"os"
 	"time"
+	"fmt"
 
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
@@ -162,6 +163,20 @@ var _ = Describe("{{ .Resource.Kind }} controller", func() {
 				found := &appsv1.Deployment{}
 				return k8sClient.Get(ctx, typeNamespaceName, found)
 			}, time.Minute, time.Second).Should(Succeed())
+
+			By("Checking the latest Status Condition added to the {{ .Resource.Kind }} instance")
+			Eventually(func() error {
+				if {{ lower .Resource.Kind }}.Status.Conditions != nil && len({{ lower .Resource.Kind }}.Status.Conditions) != 0 {
+					latestStatusCondition := {{ lower .Resource.Kind }}.Status.Conditions[len({{ lower .Resource.Kind }}.Status.Conditions)-1]
+					expectedLatestStatusCondition := metav1.Condition{Type: typeAvailable{{ .Resource.Kind }},
+						Status: metav1.ConditionTrue, Reason: "Reconciling",
+						Message: fmt.Sprintf("Deployment for custom resource (%s) with %d replicas created successfully", {{ lower .Resource.Kind }}.Name, {{ lower .Resource.Kind }}.Spec.Size)}
+					if latestStatusCondition != expectedLatestStatusCondition {
+						return fmt.Errorf("The latest status condition added to the {{ lower .Resource.Kind }} instance is not as expected")
+					}
+				}
+				return nil
+			}, time.Minute, time.Second).Should(Succeed())
 		})
 	})
 })

testdata/project-v3-with-deploy-image/controllers/busybox_controller_test.go

@@ -18,6 +18,7 @@ package controllers
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"time"
 
@@ -112,6 +113,20 @@ var _ = Describe("Busybox controller", func() {
 				found := &appsv1.Deployment{}
 				return k8sClient.Get(ctx, typeNamespaceName, found)
 			}, time.Minute, time.Second).Should(Succeed())
+
+			By("Checking the latest Status Condition added to the Busybox instance")
+			Eventually(func() error {
+				if busybox.Status.Conditions != nil && len(busybox.Status.Conditions) != 0 {
+					latestStatusCondition := busybox.Status.Conditions[len(busybox.Status.Conditions)-1]
+					expectedLatestStatusCondition := metav1.Condition{Type: typeAvailableBusybox,
+						Status: metav1.ConditionTrue, Reason: "Reconciling",
+						Message: fmt.Sprintf("Deployment for custom resource (%s) with %d replicas created successfully", busybox.Name, busybox.Spec.Size)}
+					if latestStatusCondition != expectedLatestStatusCondition {
+						return fmt.Errorf("The latest status condition added to the busybox instance is not as expected")
+					}
+				}
+				return nil
+			}, time.Minute, time.Second).Should(Succeed())
 		})
 	})
 })

testdata/project-v3-with-deploy-image/controllers/memcached_controller_test.go

@@ -18,6 +18,7 @@ package controllers
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"time"
 
@@ -113,6 +114,20 @@ var _ = Describe("Memcached controller", func() {
 				found := &appsv1.Deployment{}
 				return k8sClient.Get(ctx, typeNamespaceName, found)
 			}, time.Minute, time.Second).Should(Succeed())
+
+			By("Checking the latest Status Condition added to the Memcached instance")
+			Eventually(func() error {
+				if memcached.Status.Conditions != nil && len(memcached.Status.Conditions) != 0 {
+					latestStatusCondition := memcached.Status.Conditions[len(memcached.Status.Conditions)-1]
+					expectedLatestStatusCondition := metav1.Condition{Type: typeAvailableMemcached,
+						Status: metav1.ConditionTrue, Reason: "Reconciling",
+						Message: fmt.Sprintf("Deployment for custom resource (%s) with %d replicas created successfully", memcached.Name, memcached.Spec.Size)}
+					if latestStatusCondition != expectedLatestStatusCondition {
+						return fmt.Errorf("The latest status condition added to the memcached instance is not as expected")
+					}
+				}
+				return nil
+			}, time.Minute, time.Second).Should(Succeed())
 		})
 	})
 })

testdata/project-v4-with-deploy-image/controllers/busybox_controller_test.go

@@ -18,6 +18,7 @@ package controllers
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"time"
 
@@ -112,6 +113,20 @@ var _ = Describe("Busybox controller", func() {
 				found := &appsv1.Deployment{}
 				return k8sClient.Get(ctx, typeNamespaceName, found)
 			}, time.Minute, time.Second).Should(Succeed())
+
+			By("Checking the latest Status Condition added to the Busybox instance")
+			Eventually(func() error {
+				if busybox.Status.Conditions != nil && len(busybox.Status.Conditions) != 0 {
+					latestStatusCondition := busybox.Status.Conditions[len(busybox.Status.Conditions)-1]
+					expectedLatestStatusCondition := metav1.Condition{Type: typeAvailableBusybox,
+						Status: metav1.ConditionTrue, Reason: "Reconciling",
+						Message: fmt.Sprintf("Deployment for custom resource (%s) with %d replicas created successfully", busybox.Name, busybox.Spec.Size)}
+					if latestStatusCondition != expectedLatestStatusCondition {
+						return fmt.Errorf("The latest status condition added to the busybox instance is not as expected")
+					}
+				}
+				return nil
+			}, time.Minute, time.Second).Should(Succeed())
 		})
 	})
 })

testdata/project-v4-with-deploy-image/controllers/memcached_controller_test.go

@@ -18,6 +18,7 @@ package controllers
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"time"
 
@@ -113,6 +114,20 @@ var _ = Describe("Memcached controller", func() {
 				found := &appsv1.Deployment{}
 				return k8sClient.Get(ctx, typeNamespaceName, found)
 			}, time.Minute, time.Second).Should(Succeed())
+
+			By("Checking the latest Status Condition added to the Memcached instance")
+			Eventually(func() error {
+				if memcached.Status.Conditions != nil && len(memcached.Status.Conditions) != 0 {
+					latestStatusCondition := memcached.Status.Conditions[len(memcached.Status.Conditions)-1]
+					expectedLatestStatusCondition := metav1.Condition{Type: typeAvailableMemcached,
+						Status: metav1.ConditionTrue, Reason: "Reconciling",
+						Message: fmt.Sprintf("Deployment for custom resource (%s) with %d replicas created successfully", memcached.Name, memcached.Spec.Size)}
+					if latestStatusCondition != expectedLatestStatusCondition {
+						return fmt.Errorf("The latest status condition added to the memcached instance is not as expected")
+					}
+				}
+				return nil
+			}, time.Minute, time.Second).Should(Succeed())
 		})
 	})
 })