Skip to content

Commit e0b66dc

Browse files
committed
use controller-runtime modify finalizer
1 parent 3da7f18 commit e0b66dc

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

docs/book/src/cronjob-tutorial/testdata/finalizer_example.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
"k8s.io/kubernetes/pkg/apis/batch"
2828
ctrl "sigs.k8s.io/controller-runtime"
2929
"sigs.k8s.io/controller-runtime/pkg/client"
30+
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
3031

3132
batchv1 "tutorial.kubebuilder.io/project/api/v1"
3233
)
@@ -66,7 +67,7 @@ func (r *CronJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
6667
// then lets add the finalizer and update the object. This is equivalent
6768
// registering our finalizer.
6869
if !containsString(cronJob.GetFinalizers(), myFinalizerName) {
69-
cronJob.SetFinalizers(append(cronJob.GetFinalizers(), myFinalizerName))
70+
controllerutil.AddFinalizer(cronJob, myFinalizerName)
7071
if err := r.Update(ctx, cronJob); err != nil {
7172
return ctrl.Result{}, err
7273
}
@@ -82,7 +83,7 @@ func (r *CronJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
8283
}
8384

8485
// remove our finalizer from the list and update it.
85-
cronJob.SetFinalizers(removeString(cronJob.GetFinalizers(), myFinalizerName))
86+
controllerutil.RemoveFinalizer(cronJob, myFinalizerName)
8687
if err := r.Update(ctx, cronJob); err != nil {
8788
return ctrl.Result{}, err
8889
}

0 commit comments

Comments
 (0)