Skip to content

Commit efc7fb5

Browse files
authored
Merge pull request #5039 from camilamacedo86/fix-alpha-update
🐛 (alpha update): ensure that by default is used merge.conflictStyle=merge to facilitate the review
2 parents 94b0e07 + 271509d commit efc7fb5

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

docs/book/src/reference/commands/alpha_update.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,13 +146,12 @@ make all
146146
### Changing Extra Git configs only during the run (does not change your ~/.gitconfig)_
147147

148148
By default, `kubebuilder alpha update` applies safe Git configs:
149-
`merge.renameLimit=999999`, `diff.renameLimit=999999`.
149+
`merge.renameLimit=999999`, `diff.renameLimit=999999`, `merge.conflictStyle=merge`
150150
You can add more, or disable them.
151151

152152
- **Add more on top of defaults**
153153
```shell
154154
kubebuilder alpha update \
155-
--git-config merge.conflictStyle=diff3 \
156155
--git-config rerere.enabled=true
157156
```
158157

pkg/cli/alpha/update.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ Other options:
5454
• --output-branch: override the output branch name.
5555
• --push: push the output branch to 'origin' after the update.
5656
• --git-config: pass per-invocation Git config as -c key=value (repeatable). When not set,
57-
defaults to -c merge.renameLimit=999999 to improve rename detection during merges.
57+
defaults are set to improve detection during merges.
5858
5959
Defaults:
6060
• --from-version / --to-version: resolved from PROJECT and the latest release if unset.
@@ -92,7 +92,11 @@ Defaults:
9292
}
9393

9494
// Defaults always on unless "disable" is present anywhere
95-
defaults := []string{"merge.renameLimit=999999", "diff.renameLimit=999999"}
95+
defaults := []string{
96+
"merge.renameLimit=999999",
97+
"diff.renameLimit=999999",
98+
"merge.conflictStyle=merge",
99+
}
96100

97101
hasDisable := false
98102
filtered := make([]string, 0, len(gitCfg))
@@ -150,7 +154,7 @@ Defaults:
150154
"git-config",
151155
nil,
152156
"Per-invocation Git config (repeatable). "+
153-
"Defaults: -c merge.renameLimit=999999 -c diff.renameLimit=999999. "+
157+
"Defaults: -c merge.renameLimit=999999 -c diff.renameLimit=999999 -c merge.conflictStyle=merge. "+
154158
"Your configs are applied on top. To disable defaults, include `--git-config disable`")
155159
return updateCmd
156160
}

0 commit comments

Comments
 (0)