Merge pull request #2072 from Adirio/fix-config-registry-api

k8s-ci-robot · web-flow · commit f0ab1791f340 · 2021-03-10T04:05:14.000-08:00
🌱 Fix the config registry public API
diff --git a/pkg/config/registry.go b/pkg/config/registry.go
@@ -16,14 +16,12 @@ limitations under the License.
 
 package config
 
-type constructorFunc func() Config
-
 var (
-	registry = make(map[Version]constructorFunc)
+	registry = make(map[Version]func() Config)
 )
 
 // Register allows implementations of Config to register themselves so that they can be created with New
-func Register(version Version, constructor constructorFunc) {
+func Register(version Version, constructor func() Config) {
 	registry[version] = constructor
 }
 
diff --git a/pkg/config/resgistry_test.go b/pkg/config/resgistry_test.go
@@ -28,7 +28,7 @@ var _ = Describe("registry", func() {
 	)
 
 	AfterEach(func() {
-		registry = make(map[Version]constructorFunc)
+		registry = make(map[Version]func() Config)
 	})
 
 	Context("Register", func() {

Original file line number	Diff line number	Diff line change
`@@ -16,14 +16,12 @@ limitations under the License.`
`16`	`16`
`17`	`17`	`package config`
`18`	`18`
`19`		`-type constructorFunc func() Config`
`20`		`-`
`21`	`19`	`var (`
`22`		`- registry = make(map[Version]constructorFunc)`
	`20`	`+ registry = make(map[Version]func() Config)`
`23`	`21`	`)`
`24`	`22`
`25`	`23`	`// Register allows implementations of Config to register themselves so that they can be created with New`
`26`		`-func Register(version Version, constructor constructorFunc) {`
	`24`	`+func Register(version Version, constructor func() Config) {`
`27`	`25`	`registry[version] = constructor`
`28`	`26`	`}`
`29`	`27`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ var _ = Describe("registry", func() {`
`28`	`28`	`)`
`29`	`29`
`30`	`30`	`AfterEach(func() {`
`31`		`- registry = make(map[Version]constructorFunc)`
	`31`	`+ registry = make(map[Version]func() Config)`
`32`	`32`	`})`
`33`	`33`
`34`	`34`	`Context("Register", func() {`