Skip to content

Commit f68c3cb

Browse files
made corrections in **controller.go and **controller_test.go scaffolds
1 parent 4772b4f commit f68c3cb

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

pkg/plugins/golang/deploy-image/v1alpha1/scaffolds/api.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ func (s *apiScaffolder) Scaffold() error {
105105

106106
controller := &controllers.Controller{
107107
ControllerRuntimeVersion: golangv3scaffolds.ControllerRuntimeVersion,
108-
Image: s.image,
109108
}
110109
if err := scaffold.Execute(
111110
controller,
@@ -122,7 +121,7 @@ func (s *apiScaffolder) Scaffold() error {
122121
}
123122

124123
if err := scaffold.Execute(
125-
&controllers.ControllerTest{},
124+
&controllers.ControllerTest{Port: s.port},
126125
); err != nil {
127126
return fmt.Errorf("error creating controllers/**_controller_test.go: %v", err)
128127
}

pkg/plugins/golang/deploy-image/v1alpha1/scaffolds/internal/templates/controllers/controller-test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ type ControllerTest struct {
3434
machinery.ResourceMixin
3535

3636
Image string
37+
Port string
3738
}
3839

3940
// SetTemplateDefaults implements file.Template
@@ -103,6 +104,9 @@ var _ = Describe("{{ .Resource.Kind }} controller", func() {
103104
},
104105
Spec: {{ .Resource.ImportAlias }}.{{ .Resource.Kind }}Spec{
105106
Size: 1,
107+
{{ if not (isEmptyStr .Port) -}}
108+
ContainerPort: {{ .Port }},
109+
{{- end }}
106110
},
107111
}
108112
fmt.Fprintf(GinkgoWriter, fmt.Sprintf("Creating a new custom resource in the namespace: %s with the name %s\n", {{ lower .Resource.Kind }}.Namespace, {{ lower .Resource.Kind }}.Name))

pkg/plugins/golang/deploy-image/v1alpha1/scaffolds/internal/templates/controllers/controller.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ type Controller struct {
3535
machinery.ProjectNameMixin
3636

3737
ControllerRuntimeVersion string
38-
39-
Image string
4038
}
4139

4240
// SetTemplateDefaults implements file.Template

testdata/project-v3-with-deploy-image/controllers/memcached_controller_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ var _ = Describe("Memcached controller", func() {
5959
Namespace: MemcachedNamespace,
6060
},
6161
Spec: examplecomv1alpha1.MemcachedSpec{
62-
Size: 1,
62+
Size: 1,
63+
ContainerPort: 11211,
6364
},
6465
}
6566
fmt.Fprintf(GinkgoWriter, fmt.Sprintf("Creating a new custom resource in the namespace: %s with the name %s\n", memcached.Namespace, memcached.Name))

testdata/project-v4-with-deploy-image/controllers/memcached_controller_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ var _ = Describe("Memcached controller", func() {
5959
Namespace: MemcachedNamespace,
6060
},
6161
Spec: examplecomv1alpha1.MemcachedSpec{
62-
Size: 1,
62+
Size: 1,
63+
ContainerPort: 11211,
6364
},
6465
}
6566
fmt.Fprintf(GinkgoWriter, fmt.Sprintf("Creating a new custom resource in the namespace: %s with the name %s\n", memcached.Namespace, memcached.Name))

0 commit comments

Comments
 (0)