Follow up on #4855

[smv5309]

My apologies I do not seem to have the permissions to re open the discussion in #4855

We can answer this here or on the old thread my comment/question is the same.

Two things:

1. am i reading this correctly I need to uncomment out the following

+kubebuilder:scaffold:crdkustomizecainjectionns
it says in the code: # Do not remove or uncomment the following scaffold marker; required to generate code for target CRD.

2. All of the code that you highlighted exists in my project. I physically made a new kubebuilder project with the newer version and moved my crd, types and controller code into the new project Note using Kubebuilder Version v4.6.0. I set up my webhooks using the new commands and followed the https://book-v3.book.kubebuilder.io/multiversion-tutorial/deployment guide. Specifically I uncommented all of the labeled portions in config/default/kustomization.yaml that you outline in the response, the documentation, and made sure any code following this was uncommented: # Uncomment the following block if you have a ConversionWebhook (--conversion)

These TSL errors still persist in the same form. Are there any alternative ideas?
Examples:
[https://x-operator-webhook-service.x-operator-system.svc:443/convert](https://x-operator-webhook-service.x-operator-system.svc/convert)? timeout=30s": no endpoints available for service "x-operator-webhook-service"

cert-manager-webhook logs:
"http:TLS handshake error from 10.150.0.0:35564: EOF"

I have yet to uncomment out the skaffold line listed above its the only thing i have not tried.

[camilamacedo86]

Could you please create an issue with a minimal reproducible sample, or share the repository of your project?

It seems like something required might not have been uncommented properly.

Starting from release v4.7.0, when users scaffold a webhook, the tool automatically uncomments all the necessary sections to simplify the setup. You might want to try using the latest release to see if the issue persists.

In this discussion, I tried to highlight all the areas that should be verified. However, it’s easy to miss a step—which is exactly why this process was streamlined in v4.7.0.

The webhook implementation is well covered by our end-to-end tests, so this most likely indicates a mismatch or a configuration issue—possibly related to the webhook certificates.

[smv5309]

I was able to solve this issue eventually. I don't know if it requires a ticket but when the webhook files are created/scaffolded using the kubebuilder commands the webhook service was created with the incorrect label selector.

kind: Service
metadata:
  labels:
    app.kubernetes.io/name: my-operator
    app.kubernetes.io/managed-by: kustomize
  name: webhook-service
  namespace: system
spec:
  ports:
    - port: 443
      protocol: TCP
      targetPort: 9443
  selector:
    control-plane: controller-manager
    app.kubernetes.io/name: operator

note the different labeled app.kubernetes.io/name: operator vs app.kubernetes.io/name: my-operator. I have changed the names but essentially my project was named my-operator and everything was skaffolded with that label.

The webhook service however was created with the selector set to app.kubernetes.io/name: operator

Example solution:

  selector:
    control-plane: controller-manager
    app.kubernetes.io/name: my-operator

This was preventing the endpoint from being set/reached when you deployed a CRD manifest causing the TSL handshake errors.

[camilamacedo86]

Hey! 👋

If you’d like to customize something, I suggest making the change here:
https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/config/default/kustomization.yaml#L9

Just a heads-up:
The Operator name comes from your directory name, and it’s used in several places — including the PROJECT file — to track important settings.

You’re totally free to customize the scaffold however you like.
But please make sure you fully understand the changes and how they may affect your project.

For example:

• The tool might stop generating the correct scaffolds.
• You might face issues when upgrading to the latest versions (we're actively working on automation for upgrades).
• Heavy customizations might make maintenance harder down the road.

📘 More info: https://book.kubebuilder.io/migrations
Please give it a read to get a better picture!

My recommendation:

• Only change the default layout if you really need to.
• Use the tool to scaffold files whenever possible.

If you hit any problems or limitations, please open an issue — we’re happy to help and always looking to improve the tool for the community!

And of course, contributions are welcome — feel free to send PRs too! 🙌

[camilamacedo86]

Closing this one as sorted out, since you could verify that the issue was a result of customisations made that do not match the expected configuration. Thank you.