Skip to content

🌱 (CLI - Alpha) Introduce Mockable getExecutablePath for Testing in Generate #5102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🌱 (CLI - Alpha) Introduce Mockable getExecutablePath for Testing in Generate #5102

wants to merge 1 commit into from
+5 −2

Conversation

mayuka-c
Copy link
Contributor

This PR refactors the generate.go file to make the getExecutablePath function mockable, enabling better testability for functions that rely on it.

The Executable func was introduced as part of this PR: #5081 which makes the os to use currently running executable which would fail for our UTs as it would try to use testing executable. With this change, it would enable us to mock according to our testing needs.

Here's the UT PR which I'm currently working on where I had made this change and validated: #5074.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mayuka-c
Once this PR has been reviewed and has the lgtm label, please assign kavinjsir for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @mayuka-c. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2025
@mayuka-c mayuka-c mentioned this pull request Sep 16, 2025
Open
@mayuka-c mayuka-c changed the title 🌱 Introduce Mockable getExecutablePath for Testing in Generate 🌱 (CLI - Alpha) Introduce Mockable getExecutablePath for Testing in Generate Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayuka-c @k8s-ci-robot