Skip to content

Add dns-autoscaler ConfigMap template (#12789) #12811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hadi2f244 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

Add dns-autoscaler ConfigMap template (#12789) #12811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions roles/kubernetes-apps/ansible/templates/dns-autoscaler-configmap.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: dns-autoscaler{{ coredns_ordinal_suffix }}
namespace: kube-system
labels:
k8s-app: dns-autoscaler{{ coredns_ordinal_suffix }}
addonmanager.kubernetes.io/mode: Reconcile
data:
linear: '{"preventSinglePointFailure":{{ dns_prevent_single_point_failure }},"coresPerReplica":{{ dns_cores_per_replica }},"nodesPerReplica":{{ dns_nodes_per_replica }},"min":{{ dns_min_replicas }}}'
1 change: 1 addition & 0 deletions roles/kubernetes-apps/ansible/vars/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
dns_autoscaler_manifests:
- dns-autoscaler-sa.yml.j2
- dns-autoscaler.yml.j2
- dns-autoscaler-configmap.yml.j2
Comment on lines 4 to +5
Copy link

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ConfigMap should be created before the Deployment that references it. The dns-autoscaler deployment references this ConfigMap via the --configmap flag, but the ConfigMap is listed after the deployment in the manifest list. This could cause the deployment to fail or behave unexpectedly if it starts before the ConfigMap is created. Move dns-autoscaler-configmap.yml.j2 to line 4, before dns-autoscaler.yml.j2.

Suggested change
- dns-autoscaler.yml.j2
- dns-autoscaler-configmap.yml.j2
- dns-autoscaler-configmap.yml.j2
- dns-autoscaler.yml.j2

Copilot uses AI. Check for mistakes.
- dns-autoscaler-clusterrole.yml.j2
- dns-autoscaler-clusterrolebinding.yml.j2

Expand Down