Merge pull request #5155 from ephesused/eliminate-unnecessary-rnode

k8s-ci-robot · web-flow · commit 9407e26433f2 · 2023-05-09T15:27:55.000-07:00
perf: eliminate unnecessary RNode creation
diff --git a/kyaml/yaml/rnode.go b/kyaml/yaml/rnode.go
@@ -450,15 +450,13 @@ func (rn *RNode) getMetaData() *yaml.Node {
 	if IsMissingOrNull(rn) {
 		return nil
 	}
-	var n *RNode
+	content := rn.Content()
 	if rn.YNode().Kind == DocumentNode {
 		// get the content if this is the document node
-		n = NewRNode(rn.Content()[0])
-	} else {
-		n = rn
+		content = content[0].Content
 	}
 	var mf *yaml.Node
-	visitMappingNodeFields(n.Content(), func(key, value *yaml.Node) {
+	visitMappingNodeFields(content, func(key, value *yaml.Node) {
 		if !IsYNodeNilOrEmpty(value) {
 			mf = value
 		}

Original file line number	Diff line number	Diff line change
`@@ -450,15 +450,13 @@ func (rn RNode) getMetaData() yaml.Node {`
`450`	`450`	`if IsMissingOrNull(rn) {`
`451`	`451`	`return nil`
`452`	`452`	`}`
`453`		`- var n *RNode`
	`453`	`+ content := rn.Content()`
`454`	`454`	`if rn.YNode().Kind == DocumentNode {`
`455`	`455`	`// get the content if this is the document node`
`456`		`- n = NewRNode(rn.Content()[0])`
`457`		`- } else {`
`458`		`- n = rn`
	`456`	`+ content = content[0].Content`
`459`	`457`	`}`
`460`	`458`	`var mf *yaml.Node`
`461`		`- visitMappingNodeFields(n.Content(), func(key, value *yaml.Node) {`
	`459`	`+ visitMappingNodeFields(content, func(key, value *yaml.Node) {`
`462`	`460`	`if !IsYNodeNilOrEmpty(value) {`
`463`	`461`	`mf = value`
`464`	`462`	`}`