Skip to content

Commit cef9cc1

Browse files
milkshake308Mrflatt
authored andcommitted
feat: add test cases for helm devel
1 parent 4a7807a commit cef9cc1

File tree

2 files changed

+57
-0
lines changed

2 files changed

+57
-0
lines changed

api/types/helmchartargs_test.go

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,4 +77,28 @@ func TestAsHelmArgs(t *testing.T) {
7777
"-f", "values2",
7878
"--debug"})
7979
})
80+
81+
t.Run("use helm-devel", func(t *testing.T) {
82+
// We first test that the devel flag is only appended when specified
83+
p := types.HelmChart{
84+
Name: "chart-name",
85+
Version: "1.0.0",
86+
Repo: "https://helm.releases.hashicorp.com",
87+
ValuesFile: "values",
88+
AdditionalValuesFiles: []string{"values1", "values2"},
89+
}
90+
require.Equal(t, p.AsHelmArgs("/home/charts"),
91+
[]string{"template", "--generate-name", "/home/charts/chart-name",
92+
"-f", "values",
93+
"-f", "values1",
94+
"-f", "values2"})
95+
96+
p.Devel = true
97+
require.Equal(t, p.AsHelmArgs("/home/charts"),
98+
[]string{"template", "--generate-name", "/home/charts/chart-name",
99+
"-f", "values",
100+
"-f", "values1",
101+
"-f", "values2",
102+
"--devel"})
103+
})
80104
}

plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator_test.go

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -993,3 +993,36 @@ debug: true
993993
assert.Contains(t, string(chartYamlContent), "name: test-chart")
994994
assert.Contains(t, string(chartYamlContent), "version: 1.0.0")
995995
}
996+
997+
func TestHelmChartInflationGeneratorWithDevel(t *testing.T) {
998+
th := kusttest_test.MakeEnhancedHarnessWithTmpRoot(t).
999+
PrepBuiltin("HelmChartInflationGenerator")
1000+
defer th.Reset()
1001+
if err := th.ErrIfNoHelm(); err != nil {
1002+
t.Skip("skipping: " + err.Error())
1003+
}
1004+
copyTestChartsIntoHarness(t, th)
1005+
1006+
rm := th.LoadAndRunGenerator(`
1007+
apiVersion: builtin
1008+
kind: HelmChartInflationGenerator
1009+
metadata:
1010+
name: test-chart
1011+
name: test-chart
1012+
version: 0.1.0-Beta
1013+
repo: https://charts.bitwarden.com/
1014+
releaseName: sm-operator
1015+
devel: true
1016+
`)
1017+
cm, err := rm.Resources()[0].GetFieldValue("metadata.name")
1018+
require.NoError(t, err)
1019+
assert.Equal(t, "bar", cm)
1020+
1021+
chartDir := filepath.Join(th.GetRoot(), "charts/test-chart")
1022+
assert.True(t, th.GetFSys().Exists(chartDir))
1023+
1024+
chartYamlContent, err := th.GetFSys().ReadFile(filepath.Join(chartDir, "Chart.yaml"))
1025+
require.NoError(t, err)
1026+
assert.Contains(t, string(chartYamlContent), "name: test-chart")
1027+
assert.Contains(t, string(chartYamlContent), "version: 0.1.0-Beta")
1028+
}

0 commit comments

Comments
 (0)