Skip to content

Commit d78fe66

Browse files
committed
add commentaries, change command order on presubmit-check
1 parent 532abf7 commit d78fe66

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

Makefile

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,13 @@ verify-kustomize-repo: \
108108
.PHONY: prow-presubmit-check
109109
prow-presubmit-check: \
110110
install-tools \
111+
workspace-sync \
112+
generate-kustomize-builtin-plugins \
111113
test-unit-kustomize-plugins \
112114
test-go-mod \
113115
build-non-plugin-all \
114116
test-examples-kustomize-against-HEAD \
115-
test-examples-kustomize-against-latest-release \
116-
workspace-sync \
117-
generate-kustomize-builtin-plugins
117+
test-examples-kustomize-against-latest-release
118118

119119
.PHONY: license
120120
license: $(MYGOBIN)/addlicense
@@ -183,10 +183,6 @@ test-examples-kustomize-against-HEAD: $(MYGOBIN)/kustomize $(MYGOBIN)/mdrip
183183
test-examples-kustomize-against-latest-release: $(MYGOBIN)/mdrip
184184
./hack/testExamplesAgainstKustomize.sh v5@$(LATEST_RELEASE)
185185

186-
.PHONY: generate-kustomize-builtin-plugins
187-
generate-kustomize-builtin-plugins:
188-
$(MAKE) -f Makefile-plugin.mk
189-
190186
# Pushes dependencies in the go.work file back to go.mod files of each workspace module.
191187
.PHONY: workspace-sync
192188
workspace sync:

Makefile-plugins.mk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ generate-kustomize-builtin-plugins: $(builtplugins)
101101
cd ../../../; \
102102
make no-diff \
103103

104+
# Check for diff, if diff is found, throw error code 1 (subject to change based on discussion)
104105
.PHONY: no-diff
105106
no-diff: $(builtplugins)
106107
for file in $(abspath $(builtinplugins)); do \

0 commit comments

Comments
 (0)