Skip to content

Commit f23d45f

Browse files
authored
Add deprecation warning message to commonLabels (#5464)
* Add commonLabels deprecation warning message * Add test * Add warningToRunEditFix message
1 parent 0b4974e commit f23d45f

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

api/types/kustomization.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ const (
188188
deprecatedPatchesJson6902Message = "# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead." + " " + deprecatedWarningToRunEditFix
189189
deprecatedPatchesStrategicMergeMessage = "# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead." + " " + deprecatedWarningToRunEditFix
190190
deprecatedVarsMessage = "# Warning: 'vars' is deprecated. Please use 'replacements' instead." + " " + deprecatedWarningToRunEditFixExperimential
191+
deprecatedCommonLabelsWarningMessage = "# Warning: 'commonLabels' is deprecated. Please use 'labels' instead." + " " + deprecatedWarningToRunEditFix
191192
)
192193

193194
// CheckDeprecatedFields check deprecated field is used or not.
@@ -196,6 +197,9 @@ func (k *Kustomization) CheckDeprecatedFields() *[]string {
196197
if k.Bases != nil {
197198
warningMessages = append(warningMessages, deprecatedBaseWarningMessage)
198199
}
200+
if k.CommonLabels != nil {
201+
warningMessages = append(warningMessages, deprecatedCommonLabelsWarningMessage)
202+
}
199203
if k.ImageTags != nil {
200204
warningMessages = append(warningMessages, deprecatedImageTagsWarningMessage)
201205
}

api/types/kustomization_test.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,13 @@ func TestKustomization_CheckDeprecatedFields(t *testing.T) {
2929
},
3030
want: &[]string{deprecatedBaseWarningMessage},
3131
},
32+
{
33+
name: "using_CommonLabels",
34+
k: Kustomization{
35+
CommonLabels: map[string]string{},
36+
},
37+
want: &[]string{deprecatedCommonLabelsWarningMessage},
38+
},
3239
{
3340
name: "using_ImageTags",
3441
k: Kustomization{
@@ -61,13 +68,15 @@ func TestKustomization_CheckDeprecatedFields(t *testing.T) {
6168
name: "usingAll",
6269
k: Kustomization{
6370
Bases: []string{"base"},
71+
CommonLabels: map[string]string{},
6472
ImageTags: []Image{},
6573
PatchesJson6902: []Patch{},
6674
PatchesStrategicMerge: []PatchStrategicMerge{},
6775
Vars: []Var{},
6876
},
6977
want: &[]string{
7078
deprecatedBaseWarningMessage,
79+
deprecatedCommonLabelsWarningMessage,
7180
deprecatedImageTagsWarningMessage,
7281
deprecatedPatchesJson6902Message,
7382
deprecatedPatchesStrategicMergeMessage,

0 commit comments

Comments
 (0)