From a0e99d20b41b078e13469fb305292b354c7270b3 Mon Sep 17 00:00:00 2001 From: Tom Pantelis Date: Fri, 29 Aug 2025 00:09:38 -0400 Subject: [PATCH] Relax criteria for the "Local service not impacted" E2E test This test has been failing intermittently for a while: STEP: verifying a local, unexported service is reachable via cluster.local [FAILED] Timed out after 10.092s. There is no failure as the matcher passed to Eventually succeeded on its most recent iteration In [It] at: .../mcs-api/e2e/localserviceimpact_test.go:167 So the Eventually in checkAllClustersReachable: Eventually(func(g Gomega) { ... }, "10s").MustPassRepeatedly(50).Should(Succeed()) does succeed but sometimes does not do so 50 times within 10s. So we need to relax these criteria, either increase the timeout or decrease the number of times. I opted for the latter, ie 20 times. Signed-off-by: Tom Pantelis --- e2e/localserviceimpact_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/e2e/localserviceimpact_test.go b/e2e/localserviceimpact_test.go index 93a557c..01629ae 100644 --- a/e2e/localserviceimpact_test.go +++ b/e2e/localserviceimpact_test.go @@ -21,6 +21,7 @@ import ( "fmt" "math/rand" "strings" + "time" . "github.com/onsi/ginkgo/v2" . "github.com/onsi/gomega" @@ -164,7 +165,7 @@ var _ = Describe("Local service not impacted", func() { clusterID := strings.TrimSpace(string(stdout)) g.Expect(clusterID).To(BeElementOf(clusterIDs)) clusters[clusterID]++ - }, "10s").MustPassRepeatedly(50).Should(Succeed()) + }).MustPassRepeatedly(20).Within(time.Second * 10).Should(Succeed()) Expect(clusters).To(HaveEach(Not(BeZero()))) }