fix: conditionally render insecureSkipTLSVerify in APIService template

Only render insecureSkipTLSVerify field when true to prevent GitOps sync
drift. Kubernetes omits this field when false (API default), causing
ArgoCD to show resources as OutOfSync.

Author: pawl

charts/metrics-server/CHANGELOG.md

@@ -26,6 +26,10 @@
 - Update the _Addon Resizer_ OCI image to [`1.8.23`](https://github.com/kubernetes/autoscaler/releases/tag/addon-resizer-1.8.23). ([#1626](https://github.com/kubernetes-sigs/metrics-server/pull/1626)) _@stevehipwell_
 - Update the _Metrics Server_ OCI image to [`0.8.0`](https://github.com/kubernetes-sigs/metrics-server/releases/tag/v0.8.0). ([#1683](https://github.com/kubernetes-sigs/metrics-server/pull/1683)) _@stevehipwell_
 
+### Fixed
+
+- Conditionally render `insecureSkipTLSVerify` field in APIService template to prevent GitOps sync drift when value is `false`. ([#1727](https://github.com/kubernetes-sigs/metrics-server/pull/1727)) _@pawl_
+
 ## [3.12.2] - 2024-10-07
 
 ### Added

charts/metrics-server/templates/apiservice.yaml

@@ -61,7 +61,9 @@ spec:
   {{- end }}
   group: metrics.k8s.io
   groupPriorityMinimum: 100
-  insecureSkipTLSVerify: {{ .Values.apiService.insecureSkipTLSVerify }}
+  {{- with .Values.apiService.insecureSkipTLSVerify }}
+  insecureSkipTLSVerify: {{ . }}
+  {{- end }}
   service:
     name: {{ include "metrics-server.fullname" . }}
     namespace: {{ .Release.Namespace }}