fix: move unlock after read

FourFifthsCode · FourFifthsCode · commit 389fe133f10e · 2025-06-09T10:15:58.000-04:00
diff --git a/providers/kubeconfig/provider.go b/providers/kubeconfig/provider.go
@@ -205,10 +205,10 @@ func (p *Provider) handleSecret(ctx context.Context, secret *corev1.Secret, mgr
 	// Check if cluster exists and remove it if it does
 	p.lock.RLock()
 	ac, clusterExists := p.clusters[clusterName]
+	p.lock.RUnlock()
 	if clusterExists {
 		if ac.Hash == hashStr {
 			log.Info("Cluster already exists and has the same kubeconfig, skipping")
-			p.lock.RUnlock()
 			return nil
 		}
 
@@ -217,7 +217,6 @@ func (p *Provider) handleSecret(ctx context.Context, secret *corev1.Secret, mgr
 			return fmt.Errorf("failed to remove existing cluster: %w", err)
 		}
 	}
-	p.lock.RUnlock()
 
 	// Parse the kubeconfig
 	restConfig, err := clientcmd.RESTConfigFromKubeConfig(kubeconfigData)

Original file line number	Diff line number	Diff line change
`@@ -205,10 +205,10 @@ func (p Provider) handleSecret(ctx context.Context, secret corev1.Secret, mgr`
`205`	`205`	`// Check if cluster exists and remove it if it does`
`206`	`206`	`p.lock.RLock()`
`207`	`207`	`ac, clusterExists := p.clusters[clusterName]`
	`208`	`+ p.lock.RUnlock()`
`208`	`209`	`if clusterExists {`
`209`	`210`	`if ac.Hash == hashStr {`
`210`	`211`	`log.Info("Cluster already exists and has the same kubeconfig, skipping")`
`211`		`- p.lock.RUnlock()`
`212`	`212`	`return nil`
`213`	`213`	`}`
`214`	`214`
`@@ -217,7 +217,6 @@ func (p Provider) handleSecret(ctx context.Context, secret corev1.Secret, mgr`
`217`	`217`	`return fmt.Errorf("failed to remove existing cluster: %w", err)`
`218`	`218`	`}`
`219`	`219`	`}`
`220`		`- p.lock.RUnlock()`
`221`	`220`
`222`	`221`	`// Parse the kubeconfig`
`223`	`222`	`restConfig, err := clientcmd.RESTConfigFromKubeConfig(kubeconfigData)`