Skip to content

Commit 593e171

Browse files
committed
Address embik's comments
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
1 parent de7dbcd commit 593e171

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

pkg/multicluster/multicluster.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ type Aware interface {
3030
// The given context is tied to the Cluster's lifecycle and will be cancelled when the
3131
// Cluster is removed or an error occurs.
3232
//
33+
// Engage is a no-op if the passed cluster is equal to the existing, already
34+
// engaged cluster (equal means interface equality, i.e. the same instance).
35+
//
3336
// Implementers should return an error if they cannot start operations for the given Cluster,
3437
// and should ensure this operation is re-entrant and non-blocking.
3538
//

pkg/source/kind.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func TypedKind[object client.Object, request mcreconcile.ClusterAware[request]](
5656
obj: obj,
5757
handler: handler,
5858
predicates: predicates,
59-
project: func(_ cluster.Cluster, o object) (object, error) { return o, nil },
59+
project: func(_ cluster.Cluster, obj object) (object, error) { return obj, nil },
6060
resync: 0, // no periodic resync by default
6161
}
6262
}

0 commit comments

Comments
 (0)