style: fix names in errors and remove/clarify FIXMEs

Author: huntergregory

cmd/cyclonus/pkg/connectivity/stepresult.go

@@ -13,7 +13,6 @@ type StepResult struct {
 	KubeProbes     []*probe.Table
 	Policy         *matcher.Policy
 	KubePolicies   []*networkingv1.NetworkPolicy
-	// FIXME use ANP and BANP here
 	ANPs        []*v1alpha1.AdminNetworkPolicy
 	BANP        *v1alpha1.BaselineAdminNetworkPolicy
 	comparisons []*ComparisonTable

cmd/cyclonus/pkg/matcher/builder.go

@@ -58,7 +58,7 @@ func BuildTarget(netpol *networkingv1.NetworkPolicy) (*Target, *Target) {
 	var ingress *Target
 	var egress *Target
 	if len(netpol.Spec.PolicyTypes) == 0 {
-		panic(errors.Errorf("invalid network policy: need at least 1 type"))
+		panic(errors.Errorf("invalid NetworkPolicy: need at least 1 type"))
 	}
 	policyNamespace := getPolicyNamespace(netpol)
 	for _, pType := range netpol.Spec.PolicyTypes {
@@ -208,7 +208,7 @@ func BuildSinglePortMatcher(npPort networkingv1.NetworkPolicyPort) (*PortProtoco
 
 func BuildTargetANP(anp *v1alpha1.AdminNetworkPolicy) (*Target, *Target) {
 	if len(anp.Spec.Ingress) == 0 && len(anp.Spec.Egress) == 0 {
-		panic(errors.Errorf("invalid network policy: need at least one egress or ingress rule"))
+		panic(errors.Errorf("invalid AdminNetworkPolicy: need at least one egress or ingress rule"))
 	}
 
 	var ingress *Target
@@ -251,7 +251,7 @@ func BuildTargetANP(anp *v1alpha1.AdminNetworkPolicy) (*Target, *Target) {
 
 func BuildTargetBANP(banp *v1alpha1.BaselineAdminNetworkPolicy) (*Target, *Target) {
 	if len(banp.Spec.Ingress) == 0 && len(banp.Spec.Egress) == 0 {
-		panic(errors.Errorf("invalid network policy: need at least one egress or ingress rule"))
+		panic(errors.Errorf("invalid BaselineAdminNetworkPolicy: need at least one egress or ingress rule"))
 	}
 
 	var ingress *Target

cmd/cyclonus/pkg/matcher/explain.go

@@ -89,7 +89,7 @@ func (s *SliceBuilder) IPPeerMatcherTableLines(ip *IPPeerMatcher) {
 }
 
 func (s *SliceBuilder) PodPeerMatcherTableLines(nsPodMatcher *PodPeerMatcher, e Effect) {
-	// FIXME add action/priority column using e
+	// FIXME add action/priority column using fields of the Effect parameter "e"
 	var namespaces string
 	switch ns := nsPodMatcher.Namespace.(type) {
 	case *AllNamespaceMatcher: