Skip to content

Commit 0f431c7

Browse files
committed
kubectl-nfd/test: fix listing of NodeFeature objects
The informer/lister approach never returned anything because they were not started.
1 parent 4ea2711 commit 0f431c7

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

pkg/kubectl-nfd/test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,16 @@ limitations under the License.
1717
package kubectlnfd
1818

1919
import (
20+
"context"
2021
"fmt"
2122
"os"
22-
"time"
23+
"strings"
2324

25+
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2426
k8sLabels "k8s.io/apimachinery/pkg/labels"
2527
"k8s.io/client-go/tools/clientcmd"
2628

2729
nfdclientset "sigs.k8s.io/node-feature-discovery/api/generated/clientset/versioned"
28-
nfdinformers "sigs.k8s.io/node-feature-discovery/api/generated/informers/externalversions"
2930
nfdv1alpha1 "sigs.k8s.io/node-feature-discovery/api/nfd/v1alpha1"
3031

3132
"sigs.k8s.io/yaml"
@@ -46,14 +47,13 @@ func Test(nodefeaturerulepath, nodeName, kubeconfig string) []error {
4647
}
4748

4849
nfdClient := nfdclientset.NewForConfigOrDie(config)
49-
informerFactory := nfdinformers.NewSharedInformerFactory(nfdClient, 1*time.Second)
50-
featureLister := informerFactory.Nfd().V1alpha1().NodeFeatures().Lister()
5150

5251
sel := k8sLabels.SelectorFromSet(k8sLabels.Set{nfdv1alpha1.NodeFeatureObjNodeNameLabel: nodeName})
53-
objs, err := featureLister.List(sel)
52+
list, err := nfdClient.NfdV1alpha1().NodeFeatures(metav1.NamespaceAll).List(context.TODO(), metav1.ListOptions{LabelSelector: sel.String()})
5453
if err != nil {
5554
return []error{fmt.Errorf("failed to get NodeFeature resources for node %q: %w", nodeName, err)}
5655
}
56+
objs := list.Items
5757
features := nfdv1alpha1.NewNodeFeatureSpec()
5858
if len(objs) > 0 {
5959
features = objs[0].Spec.DeepCopy()

0 commit comments

Comments
 (0)