Skip to content

Commit 21b9b7a

Browse files
omerap12marquiz
omerap12
authored and
marquiz
committed
helm: add configurable liveness&readiness probes for master topology-updater and worker
Signed-off-by: Omer Aplatony <[email protected]> (cherry picked from commit b2222e2)
1 parent 92db868 commit 21b9b7a

File tree

5 files changed

+46
-50
lines changed

5 files changed

+46
-50
lines changed

‎deployment/helm/node-feature-discovery/templates/master.yaml‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,9 @@ spec:
4646
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
4747
imagePullPolicy: {{ .Values.image.pullPolicy }}
4848
livenessProbe:
49-
grpc:
50-
port: 8082
51-
initialDelaySeconds: 10
52-
periodSeconds: 10
49+
{{- toYaml .Values.master.livenessProbe | nindent 12 }}
5350
readinessProbe:
54-
grpc:
55-
port: 8082
56-
initialDelaySeconds: 5
57-
periodSeconds: 10
58-
failureThreshold: 10
51+
{{- toYaml .Values.master.readinessProbe | nindent 12 }}
5952
ports:
6053
- containerPort: {{ .Values.master.port | default "8080" }}
6154
name: grpc

‎deployment/helm/node-feature-discovery/templates/topologyupdater.yaml‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,9 @@ spec:
4343
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
4444
imagePullPolicy: "{{ .Values.image.pullPolicy }}"
4545
livenessProbe:
46-
grpc:
47-
port: 8082
48-
initialDelaySeconds: 10
49-
periodSeconds: 10
46+
{{- toYaml .Values.topologyUpdater.livenessProbe | nindent 10 }}
5047
readinessProbe:
51-
grpc:
52-
port: 8082
53-
initialDelaySeconds: 5
54-
periodSeconds: 10
55-
failureThreshold: 10
48+
{{- toYaml .Values.topologyUpdater.readinessProbe | nindent 10 }}
5649
env:
5750
- name: NODE_NAME
5851
valueFrom:

‎deployment/helm/node-feature-discovery/templates/worker.yaml‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,9 @@ spec:
4545
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
4646
imagePullPolicy: {{ .Values.image.pullPolicy }}
4747
livenessProbe:
48-
grpc:
49-
port: 8082
50-
initialDelaySeconds: 10
51-
periodSeconds: 10
48+
{{- toYaml .Values.worker.livenessProbe | nindent 12 }}
5249
readinessProbe:
53-
grpc:
54-
port: 8082
55-
initialDelaySeconds: 5
56-
periodSeconds: 10
57-
failureThreshold: 10
50+
{{- toYaml .Values.worker.readinessProbe | nindent 12 }}
5851
env:
5952
- name: NODE_NAME
6053
valueFrom:

‎deployment/helm/node-feature-discovery/values.yaml‎

Lines changed: 34 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,19 @@ master:
141141
- key: "node-role.kubernetes.io/control-plane"
142142
operator: In
143143
values: [""]
144+
145+
livenessProbe:
146+
grpc:
147+
port: 8082
148+
initialDelaySeconds: 10
149+
# failureThreshold: 3
150+
# periodSeconds: 10
151+
readinessProbe:
152+
grpc:
153+
port: 8082
154+
initialDelaySeconds: 5
155+
failureThreshold: 10
156+
# periodSeconds: 10
144157

145158
worker:
146159
enable: true
@@ -401,19 +414,18 @@ worker:
401414
runAsNonRoot: true
402415
# runAsUser: 1000
403416

404-
# livenessProbe: {}
405-
## NOTE: Currently not configurable, defaults are provided for the sake of extra documentation.
406-
# grpc:
407-
# port: 8082
408-
# initialDelaySeconds: 10
417+
livenessProbe:
418+
grpc:
419+
port: 8082
420+
initialDelaySeconds: 10
421+
# failureThreshold: 3
409422
# periodSeconds: 10
410-
# readinessProbe: {}
411-
## NOTE: Currently not configurable, defaults are provided for the sake of extra documentation.
412-
# grpc:
413-
# port: 8082
414-
# initialDelaySeconds: 5
423+
readinessProbe:
424+
grpc:
425+
port: 8082
426+
initialDelaySeconds: 5
427+
failureThreshold: 10
415428
# periodSeconds: 10
416-
# failureThreshold: 10
417429

418430
serviceAccount:
419431
# Specifies whether a service account should be created.
@@ -491,20 +503,19 @@ topologyUpdater:
491503
drop: [ "ALL" ]
492504
readOnlyRootFilesystem: true
493505
runAsUser: 0
494-
495-
# livenessProbe: {}
496-
## NOTE: Currently not configurable, defaults are provided for the sake of extra documentation.
497-
# grpc:
498-
# port: 8082
499-
# initialDelaySeconds: 10
506+
507+
livenessProbe:
508+
grpc:
509+
port: 8082
510+
initialDelaySeconds: 10
511+
# failureThreshold: 3
500512
# periodSeconds: 10
501-
# readinessProbe: {}
502-
## NOTE: Currently not configurable, defaults are provided for the sake of extra documentation.
503-
# grpc:
504-
# port: 8082
505-
# initialDelaySeconds: 5
513+
readinessProbe:
514+
grpc:
515+
port: 8082
516+
initialDelaySeconds: 5
517+
failureThreshold: 10
506518
# periodSeconds: 10
507-
# failureThreshold: 10
508519

509520
resources:
510521
limits:

‎docs/deployment/helm.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,8 @@ API's you need to install the prometheus operator in your cluster.
144144
| `master.nfdApiParallelism` | integer | 10 | Specifies the maximum number of concurrent node updates. |
145145
| `master.config` | dict | | NFD master [configuration](../reference/master-configuration-reference) |
146146
| `master.revisionHistoryLimit` | integer | | Specify how many old ReplicaSets for this Deployment you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#revision-history-limit) |
147+
| `master.livenessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":10} | NFD master pod [liveness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#liveness-probe) |
148+
| `master.readinessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":5,"failureThreshold": 10} | NFD master pod [readiness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#readiness-probe)|
147149

148150
### Worker pod parameters
149151

@@ -168,6 +170,8 @@ API's you need to install the prometheus operator in your cluster.
168170
| `worker.annotations` | dict | {} | NFD worker pod [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
169171
| `worker.daemonsetAnnotations` | dict | {} | NFD worker daemonset [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
170172
| `worker.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec) |
173+
| `worker.livenessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":10} | NFD worker pod [liveness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#liveness-probe) |
174+
| `worker.readinessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":5,"failureThreshold": 10} | NFD worker pod [readiness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#readiness-probe)|
171175

172176
### Topology updater parameters
173177

@@ -198,6 +202,8 @@ API's you need to install the prometheus operator in your cluster.
198202
| `topologyUpdater.podSetFingerprint` | bool | true | Enables compute and report of pod fingerprint in NRT objects. |
199203
| `topologyUpdater.kubeletStateDir` | string | /var/lib/kubelet | Specifies kubelet state directory path for watching state and checkpoint files. Empty value disables kubelet state tracking. |
200204
| `topologyUpdater.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec) |
205+
| `topologyUpdater.livenessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":10} | Topology updater pod [liveness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#liveness-probe) |
206+
| `topologyUpdater.readinessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":5,"failureThreshold": 10} | Topology updater pod [readiness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#readiness-probe)|
201207

202208
### Garbage collector parameters
203209

0 commit comments

Comments
 (0)