Skip to content

Commit 5b3f4ce

Browse files
authored
Merge pull request #1421 from marquiz/devel/fix-e2e
test/e2e: fix source/custom nodename test
2 parents b6419c7 + d7a91b8 commit 5b3f4ce

File tree

1 file changed

+24
-16
lines changed

1 file changed

+24
-16
lines changed

test/e2e/node_feature_discovery_test.go

Lines changed: 24 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -422,26 +422,34 @@ var _ = SIGDescribe("NFD master and worker", func() {
422422

423423
// create 2 configmaps
424424
data1 := fmt.Sprintf(`
425-
- name: %s
426-
matchOn:
427-
# default value is true
428-
- nodename:
429-
- "^%s$"`, targetLabelName, targetNodeName)
425+
- name: nodename-test-rule
426+
labels:
427+
"%s": "%s"
428+
matchFeatures:
429+
- feature: system.name
430+
matchExpressions:
431+
nodename: {op: In, value: ["%s"]}`, targetLabelName, targetLabelValue, targetNodeName)
430432

431433
cm1 := testutils.NewConfigMap("custom-config-extra-1", "custom.conf", data1)
432434
cm1, err = f.ClientSet.CoreV1().ConfigMaps(f.Namespace.Name).Create(ctx, cm1, metav1.CreateOptions{})
433435
Expect(err).NotTo(HaveOccurred())
434436

435437
data2 := fmt.Sprintf(`
436-
- name: %s
437-
value: %s
438-
matchOn:
439-
- nodename:
440-
- "^%s$"
441-
- name: nodename-test-negative
442-
matchOn:
443-
- nodename:
444-
- "thisNameShouldNeverMatch"`, targetLabelNameWildcard, targetLabelValueWildcard, targetNodeNameWildcard)
438+
- name: nodename-test-regexp-rule
439+
labels:
440+
"%s": "%s"
441+
matchFeatures:
442+
- feature: system.name
443+
matchExpressions:
444+
nodename: {op: InRegexp, value: ["^%s$"]}
445+
446+
- name: nodename-test-negative-rule
447+
labels:
448+
"nodename-test-negative": "true"
449+
matchFeatures:
450+
- feature: system.name
451+
matchExpressions:
452+
nodename: {op: In, value: ["thisNameShouldNeverMatch"]}`, targetLabelNameWildcard, targetLabelValueWildcard, targetNodeNameWildcard)
445453

446454
cm2 := testutils.NewConfigMap("custom-config-extra-2", "custom.conf", data2)
447455
cm2, err = f.ClientSet.CoreV1().ConfigMaps(f.Namespace.Name).Create(ctx, cm2, metav1.CreateOptions{})
@@ -465,8 +473,8 @@ var _ = SIGDescribe("NFD master and worker", func() {
465473
By("Verifying node labels")
466474
expectedLabels := map[string]k8sLabels{
467475
targetNodeName: {
468-
nfdv1alpha1.FeatureLabelNs + "/custom-" + targetLabelName: targetLabelValue,
469-
nfdv1alpha1.FeatureLabelNs + "/custom-" + targetLabelNameWildcard: targetLabelValueWildcard,
476+
nfdv1alpha1.FeatureLabelNs + "/" + targetLabelName: targetLabelValue,
477+
nfdv1alpha1.FeatureLabelNs + "/" + targetLabelNameWildcard: targetLabelValueWildcard,
470478
},
471479
"*": {},
472480
}

0 commit comments

Comments
 (0)