Skip to content

Commit 64eba87

Browse files
authored
Merge pull request #1534 from marquiz/devel/kustomize-cleanup
deployment/kustomize: drop the sample cert-manager overlay
2 parents b3919f3 + 09b5af7 commit 64eba87

File tree

9 files changed

+2
-181
lines changed

9 files changed

+2
-181
lines changed

deployment/overlays/samples/cert-manager/args.yaml

Lines changed: 0 additions & 9 deletions
This file was deleted.

deployment/overlays/samples/cert-manager/issuer.yaml

Lines changed: 0 additions & 41 deletions
This file was deleted.

deployment/overlays/samples/cert-manager/kustomization.yaml

Lines changed: 0 additions & 32 deletions
This file was deleted.

deployment/overlays/samples/cert-manager/master-cert.yaml

Lines changed: 0 additions & 19 deletions
This file was deleted.

deployment/overlays/samples/cert-manager/master-mounts.yaml

Lines changed: 0 additions & 13 deletions
This file was deleted.

deployment/overlays/samples/cert-manager/probes.yaml

Lines changed: 0 additions & 26 deletions
This file was deleted.

deployment/overlays/samples/cert-manager/worker-mounts.yaml

Lines changed: 0 additions & 13 deletions
This file was deleted.

deployment/overlays/samples/cert-manager/workers-cert.yaml

Lines changed: 0 additions & 17 deletions
This file was deleted.

docs/deployment/tls.md

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ the nfd-worker has been signed by the specified root certificate (-ca-file).
3636
Additional hardening can be enabled by specifying `-verify-node-name` in
3737
nfd-master args, in which case nfd-master verifies that the NodeName presented
3838
by nfd-worker matches the Common Name (CN) or a Subject Alternative Name (SAN)
39-
of its certificate. Note that `-verify-node-name` complicates certificate
40-
management and is not yet supported in the helm or kustomize deployment
41-
methods.
39+
of its certificate.
4240

4341
## Automated TLS certificate management using cert-manager
4442

@@ -58,14 +56,7 @@ kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/
5856
Alternatively, you can refer to cert-manager documentation for other
5957
installation methods such as the Helm chart they provide.
6058

61-
To use the kustomize overlay to install node-feature-discovery with TLS enabled,
62-
you may use the following:
63-
64-
```bash
65-
kubectl apply -k deployment/overlays/samples/cert-manager
66-
```
67-
68-
To make use of the helm chart, override `values.yaml` to enable both the
59+
When using the Helm chart to deploy NFD, override `values.yaml` to enable both the
6960
`tls.enabled` and `tls.certManager` options. Note that if you do not enable
7061
`tls.certManager`, helm will successfully install the application, but
7162
deployment will wait until certificates are manually created, as demonstrated

0 commit comments

Comments
 (0)