Skip to content

Commit 69dbfdf

Browse files
Use close to signal stop channedl in worker and topology-updater
Fix stop channel management on Worker and T-updater in case of multiple callers Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
1 parent 1ff7a94 commit 69dbfdf

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

pkg/nfd-topology-updater/nfd-topology-updater.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -218,10 +218,7 @@ func (w *nfdTopologyUpdater) Run() error {
218218

219219
// Stop NFD Topology Updater
220220
func (w *nfdTopologyUpdater) Stop() {
221-
select {
222-
case w.stop <- struct{}{}:
223-
default:
224-
}
221+
close(w.stop)
225222
}
226223

227224
func (w *nfdTopologyUpdater) updateNodeResourceTopology(zoneInfo v1alpha2.ZoneList, scanResponse resourcemonitor.ScanResponse, readKubeletConfig bool) error {

pkg/nfd-worker/nfd-worker.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -303,10 +303,7 @@ func (w *nfdWorker) Run() error {
303303

304304
// Stop NfdWorker
305305
func (w *nfdWorker) Stop() {
306-
select {
307-
case w.stop <- struct{}{}:
308-
default:
309-
}
306+
close(w.stop)
310307
}
311308

312309
// getGrpcClient returns client connection to the NFD gRPC server. It creates a

0 commit comments

Comments
 (0)