nfd-master: fix memory leak in nfd api-controller

marquiz · marquiz · commit 70fd3757c4ea · 2024-03-14T15:39:10.000+02:00
Fixes a memory leak that happened when stopping (and then re-starting)
the nfd api controller. The stop channel was not used properly which
caused the underlying informer to keep on running.
diff --git a/pkg/nfd-master/nfd-api-controller.go b/pkg/nfd-master/nfd-api-controller.go
@@ -123,10 +123,7 @@ func newNfdController(config *restclient.Config, nfdApiControllerOptions nfdApiC
 }
 
 func (c *nfdController) stop() {
-	select {
-	case c.stopChan <- struct{}{}:
-	default:
-	}
+	close(c.stopChan)
 }
 
 func (c *nfdController) updateOneNode(typ string, obj metav1.Object) {

Original file line number	Diff line number	Diff line change
`@@ -123,10 +123,7 @@ func newNfdController(config *restclient.Config, nfdApiControllerOptions nfdApiC`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`func (c *nfdController) stop() {`
`126`		`- select {`
`127`		`- case c.stopChan <- struct{}{}:`
`128`		`- default:`
`129`		`- }`
	`126`	`+ close(c.stopChan)`
`130`	`127`	`}`
`131`	`128`
`132`	`129`	`func (c *nfdController) updateOneNode(typ string, obj metav1.Object) {`