Skip to content

Commit 7c2110c

Browse files
authored
Merge pull request #1368 from marquiz/devel/github-template
github: add a separate issue template for patch releases
2 parents 3a21f2f + 69d6e41 commit 7c2110c

File tree

2 files changed

+48
-5
lines changed

2 files changed

+48
-5
lines changed
Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
---
2+
name: New Patch Release
3+
about: Cut a new patch release
4+
title: Release v0.x.y
5+
assignees: adrianchiris, ArangoGutierrez, fmuyassarov, jjacobelli, kad, marquiz, PiotrProkop, zvonkok
6+
7+
---
8+
9+
## Release Checklist
10+
<!--
11+
Please do not remove items from the checklist
12+
-->
13+
- [ ] Verify that the changelog in this issue is up-to-date
14+
- [ ] Run `hack/prepare-release.sh $VERSION` to turn references to point to the upcoming release
15+
(README, deployment templates, docs configuration, test/e2e flags), submit a PR against the release branch
16+
- An OWNER prepares a draft release
17+
- [ ] Create a draft release at [Github releases page](https://github.com/kubernetes-sigs/node-feature-discovery/releases)
18+
- [ ] Write the change log into the draft release
19+
- [ ] Upload release artefacts generated by `prepare-release.sh` script above to the draft release
20+
- [ ] An OWNER runs
21+
`git tag -s $VERSION`
22+
and inserts the changelog into the tag description.
23+
- [ ] An OWNER pushes the tag with
24+
`git push $VERSION`
25+
- Triggers prow to build and publish a staging container image
26+
`gcr.io/k8s-staging-nfd/node-feature-discovery:$VERSION`
27+
- Triggers build of the documentation and publish it at
28+
https://kubernetes-sigs.github.io/node-feature-discovery/0.$MAJ/
29+
- [ ] Submit a PR against [k8s.io](https://github.com/kubernetes/k8s.io), updating `registry.k8s.io/images/k8s-staging-nfd/images.yaml` to promote the container images (both "full" and "minimal" variants) to production
30+
- [ ] Wait for the PR to be merged and verify that the image (`registry.k8s.io/nfd/node-feature-discovery:$VERSION`) is available.
31+
- [ ] Publish the draft release prepared at the [Github releases page](https://github.com/kubernetes-sigs/node-feature-discovery/releases)
32+
which will also trigger a Helm repo index update to add the latest release
33+
- [ ] Add a link to the tagged release in this issue.
34+
- [ ] For a point release of the latest newest release branch, update README in master branch
35+
- [ ] Update references e.g. by running `hack/prepare-release.sh $VERSION` but **only** committing README.md, and,
36+
submit a PR
37+
- [ ] Wait for the PR to be merged
38+
- [ ] Close this issue
39+
40+
41+
## Changelog
42+
<!--
43+
Describe changes since the last release here.
44+
-->

.github/ISSUE_TEMPLATE/new-release.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Please do not remove items from the checklist
1212
-->
1313
- [ ] All [OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/OWNERS) must LGTM the release proposal
1414
- [ ] Verify that the changelog in this issue is up-to-date
15-
- [ ] For major releases (v0.$MAJ.0) create new release branch
15+
- [ ] Create new release branch (release v0.$MAJ.0)
1616
- [ ] an OWNER creates a vanilla release branch with
1717
`git branch release-0.$MAJ master`
1818
- [ ] An OWNER pushes the new release branch with
@@ -40,14 +40,13 @@ Please do not remove items from the checklist
4040
- [ ] Publish the draft release prepared at the [Github releases page](https://github.com/kubernetes-sigs/node-feature-discovery/releases)
4141
which will also trigger a Helm repo index update to add the latest release
4242
- [ ] Add a link to the tagged release in this issue.
43-
- [ ] For a major release
44-
- [ ] Send an announcement email to `[email protected]` with the subject `[ANNOUNCE] node-feature-discovery $VERSION is released`
43+
- [ ] Send an announcement email to `[email protected]` with the subject `[ANNOUNCE] node-feature-discovery $VERSION is released`
4544
- [ ] Add a link to the release announcement in this issue
46-
- [ ] For a major release (or a point release of the latest major release), update README in master branch
45+
- [ ] Update README in master branch
4746
- [ ] Update references e.g. by running `hack/prepare-release.sh $VERSION` but **only** committing README.md, and,
4847
submit a PR
4948
- [ ] Wait for the PR to be merged
50-
- [ ] For a major release, create an unannotated *devel* tag in the master branch, on the first commit that gets merged after the release branch has been created (presumably the README update commit above), and, push the tag:
49+
- [ ] Create an unannotated *devel* tag in the master branch, on the first commit that gets merged after the release branch has been created (presumably the README update commit above), and, push the tag:
5150
`DEVEL=v0.$(($MAJ+1)).0-devel; git tag $DEVEL master && git push $DEVEL`
5251
This ensures that the devel builds on the master branch will have a meaningful version number.
5352
- [ ] Close this issue

0 commit comments

Comments
 (0)