Skip to content

Commit 843fc93

Browse files
marquizmarquiz
committed
helm: rename args chart value to extraArgs
The "args" value is not yet part of any release so this is not a breaking change.
1 parent 1217773 commit 843fc93

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

‎deployment/helm/node-feature-discovery/templates/master.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ spec:
110110
- "-feature-gates={{ $key }}={{ $value }}"
111111
{{- end }}
112112
- "-metrics={{ .Values.master.metricsPort | default "8081" }}"
113-
{{- with .Values.master.args }}
113+
{{- with .Values.master.extraArgs }}
114114
{{- toYaml . | nindent 12 }}
115115
{{- end }}
116116
volumeMounts:

‎deployment/helm/node-feature-discovery/templates/nfd-gc.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ spec:
5454
{{- if .Values.gc.interval | empty | not }}
5555
- "-gc-interval={{ .Values.gc.interval }}"
5656
{{- end }}
57-
{{- with .Values.gc.args }}
57+
{{- with .Values.gc.extraArgs }}
5858
{{- toYaml . | nindent 10 }}
5959
{{- end }}
6060
resources:

‎deployment/helm/node-feature-discovery/templates/topologyupdater.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ spec:
8686
- "-kubelet-state-dir="
8787
{{- end }}
8888
- -metrics={{ .Values.topologyUpdater.metricsPort | default "8081"}}
89-
{{- with .Values.topologyUpdater.args }}
89+
{{- with .Values.topologyUpdater.extraArgs }}
9090
{{- toYaml . | nindent 10 }}
9191
{{- end }}
9292
ports:

‎deployment/helm/node-feature-discovery/templates/worker.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ spec:
8080
- "-feature-gates={{ $key }}={{ $value }}"
8181
{{- end }}
8282
- "-metrics={{ .Values.worker.metricsPort | default "8081"}}"
83-
{{- with .Values.gc.args }}
83+
{{- with .Values.gc.extraArgs }}
8484
{{- toYaml . | nindent 8 }}
8585
{{- end }}
8686
ports:

‎docs/deployment/helm.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ API's you need to install the prometheus operator in your cluster.
203203
| `master.deploymentAnnotations` | dict | {} | NFD master deployment [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
204204
| `master.nfdApiParallelism` | integer | 10 | Specifies the maximum number of concurrent node updates. |
205205
| `master.config` | dict | | NFD master [configuration](../reference/master-configuration-reference) |
206-
| `master.args` | array | [] | Additional [command line arguments](../reference/master-commandline-reference.md) to pass to nfd-master |
206+
| `master.extraArgs` | array | [] | Additional [command line arguments](../reference/master-commandline-reference.md) to pass to nfd-master |
207207
| `master.revisionHistoryLimit` | integer | | Specify how many old ReplicaSets for this Deployment you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#revision-history-limit) |
208208
| `master.livenessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":10} | NFD master pod [liveness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#liveness-probe) |
209209
| `master.readinessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":5,"failureThreshold": 10} | NFD master pod [readiness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#readiness-probe)|
@@ -230,7 +230,7 @@ API's you need to install the prometheus operator in your cluster.
230230
| `worker.priorityClassName` | string | | NFD worker pod [priority class](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/) |
231231
| `worker.annotations` | dict | {} | NFD worker pod [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
232232
| `worker.daemonsetAnnotations` | dict | {} | NFD worker daemonset [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
233-
| `worker.args` | array | [] | Additional [command line arguments](../reference/worker-commandline-reference.md) to pass to nfd-worker |
233+
| `worker.extraArgs` | array | [] | Additional [command line arguments](../reference/worker-commandline-reference.md) to pass to nfd-worker |
234234
| `worker.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/ #DaemonSetSpec) |
235235
| `worker.livenessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":10} | NFD worker pod [liveness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#liveness-probe) |
236236
| `worker.readinessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":5,"failureThreshold": 10} | NFD worker pod [readiness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#readiness-probe)|
@@ -263,7 +263,7 @@ API's you need to install the prometheus operator in your cluster.
263263
| `topologyUpdater.config` | dict | | [configuration](../reference/topology-updater-configuration-reference) |
264264
| `topologyUpdater.podSetFingerprint` | bool | true | Enables compute and report of pod fingerprint in NRT objects. |
265265
| `topologyUpdater.kubeletStateDir` | string | /var/lib/kubelet | Specifies kubelet state directory path for watching state and checkpoint files. Empty value disables kubelet state tracking. |
266-
| `topologyUpdater.args` | array | [] | Additional [command line arguments](../reference/topology-updater-commandline-reference.md) to pass to nfd-topology-updater |
266+
| `topologyUpdater.extraArgs` | array | [] | Additional [command line arguments](../reference/topology-updater-commandline-reference.md) to pass to nfd-topology-updater |
267267
| `topologyUpdater.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec) |
268268
| `topologyUpdater.livenessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":10} | Topology updater pod [liveness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#liveness-probe) |
269269
| `topologyUpdater.readinessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":5,"failureThreshold": 10} | Topology updater pod [readiness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#readiness-probe)|
@@ -288,7 +288,7 @@ API's you need to install the prometheus operator in your cluster.
288288
| `gc.annotations` | dict | {} | Garbage collector pod [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
289289
| `gc.deploymentAnnotations` | dict | {} | Garbage collector deployment [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
290290
| `gc.affinity` | dict | {} | Garbage collector pod [affinity](https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/) |
291-
| `gc.args` | array | [] | Additional [command line arguments](../reference/gc-commandline-reference.md) to pass to nfd-gc |
291+
| `gc.extraArgs` | array | [] | Additional [command line arguments](../reference/gc-commandline-reference.md) to pass to nfd-gc |
292292
| `gc.revisionHistoryLimit` | integer | | Specify how many old ReplicaSets for this Deployment you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#revision-history-limit) |
293293

294294
<!-- Links -->

0 commit comments

Comments
 (0)