Add unit tests for huge pages detection

Signed-off-by: Marcin Franczyk <[email protected]>

Author: mfranczy

source/memory/memory.go

@@ -237,7 +237,7 @@ func getHugePageSize(basePath, dirName string, reg *regexp.Regexp) (string, erro
 	totalPagesFile := filepath.Join(basePath, dirName, "nr_hugepages")
 	totalPagesRaw, err := os.ReadFile(totalPagesFile)
 	if err != nil {
-		return "", fmt.Errorf("unable to read total number of huge pages from the file name: %s", totalPagesFile)
+		return "", fmt.Errorf("unable to read total number of huge pages from the file: %s", totalPagesFile)
 	}
 
 	totalPages, err := strconv.Atoi(strings.TrimSpace(string(totalPagesRaw)))

source/memory/memory_test.go

@@ -17,9 +17,13 @@ limitations under the License.
 package memory
 
 import (
+	"regexp"
 	"testing"
 
+	. "github.com/smartystreets/goconvey/convey"
 	"github.com/stretchr/testify/assert"
+
+	"sigs.k8s.io/node-feature-discovery/pkg/utils/hostpath"
 )
 
 func TestMemorySource(t *testing.T) {
@@ -61,3 +65,54 @@ func TestGetNumberofLinesFromFile(t *testing.T) {
 		assert.Equal(t, tc.expectedLines, actual, "lines should match")
 	}
 }
+
+func TestDetectHugePages(t *testing.T) {
+
+	Convey("With configured 1Gi huge pages size", t, func() {
+		hostpath.SysfsDir = "testdata/hugepages"
+
+		expectedHugePages := map[string]string{
+			"enabled":       "true",
+			"hugepages-1Gi": "true",
+		}
+		hugePages, err := detectHugePages()
+		assert.Nil(t, err)
+		assert.Equal(t, hugePages, expectedHugePages)
+	})
+
+	Convey("With invalid directory structure", t, func() {
+		hostpath.SysfsDir = "invalid-dir"
+
+		expectedHugePages := map[string]string{
+			"enabled": "false",
+		}
+		hugePages, err := detectHugePages()
+		assert.Nil(t, err)
+		assert.Equal(t, hugePages, expectedHugePages)
+	})
+
+}
+
+func TestGetHugePagesSize(t *testing.T) {
+
+	re := regexp.MustCompile(`hugepages-(\d+)`)
+
+	Convey("With configured total huge pages", t, func() {
+		hugePage, err := getHugePageSize("testdata/hugepages/kernel/mm/hugepages", "hugepages-1048576kB", re)
+		assert.Equal(t, "hugepages-1Gi", hugePage)
+		assert.Nil(t, err)
+	})
+
+	Convey("With not configured total huge pages", t, func() {
+		hugePage, err := getHugePageSize("testdata/hugepages/kernel/mm/hugepages", "hugepages-2048kB", re)
+		assert.Equal(t, "", hugePage)
+		assert.NotNil(t, err)
+	})
+
+	Convey("With invalid huge page directory", t, func() {
+		hugePage, err := getHugePageSize("testdata/hugepages/kernel/mm/hugepages", "hugepages-invalid", re)
+		assert.Equal(t, "", hugePage)
+		assert.NotNil(t, err)
+	})
+
+}

source/memory/testdata/hugepages/kernel/mm/hugepages/hugepages-1048576kB/nr_hugepages

@@ -0,0 +1 @@
+2