Skip to content

Commit 94ab447

Browse files
committed
Makefile: add -timeout argument to e2e-tests
Fixes recently experienced timeouts in e2e-tests. For some reason -test.timeout was not enough (anymore).
1 parent 03f1f75 commit 94ab447

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -194,24 +194,24 @@ test:
194194

195195
e2e-test:
196196
@if [ -z ${KUBECONFIG} ]; then echo "[ERR] KUBECONFIG missing, must be defined"; exit 1; fi
197-
$(GO_CMD) test -v ./test/e2e/ -args -nfd.repo=$(IMAGE_REPO) -nfd.tag=$(IMAGE_TAG_NAME) \
197+
$(GO_CMD) test -timeout=1h -v ./test/e2e/ -args \
198+
-nfd.repo=$(IMAGE_REPO) -nfd.tag=$(IMAGE_TAG_NAME) \
198199
-kubeconfig=$(KUBECONFIG) \
199200
-nfd.e2e-config=$(E2E_TEST_CONFIG) \
200201
-nfd.pull-if-not-present=$(E2E_PULL_IF_NOT_PRESENT) \
201202
-ginkgo.focus="\[k8s-sigs\/node-feature-discovery\]" \
202203
-ginkgo.label-filter=$(E2E_GINKGO_LABEL_FILTER) \
203204
-ginkgo.v \
204-
-test.timeout=1h \
205205
$(if $(OPENSHIFT),-nfd.openshift,)
206206
if [ "$(E2E_TEST_FULL_IMAGE)" = "true" ]; then \
207-
$(GO_CMD) test -v ./test/e2e/ -args -nfd.repo=$(IMAGE_REPO) -nfd.tag=$(IMAGE_TAG_NAME)-full \
207+
$(GO_CMD) test -timeout=1h -v ./test/e2e/ -args \
208+
-nfd.repo=$(IMAGE_REPO) -nfd.tag=$(IMAGE_TAG_NAME)-full \
208209
-kubeconfig=$(KUBECONFIG) \
209210
-nfd.e2e-config=$(E2E_TEST_CONFIG) \
210211
-nfd.pull-if-not-present=$(E2E_PULL_IF_NOT_PRESENT) \
211212
-ginkgo.focus="\[k8s-sigs\/node-feature-discovery\]" \
212213
-ginkgo.label-filter=$(E2E_GINKGO_LABEL_FILTER) \
213214
-ginkgo.v \
214-
-test.timeout=1h \
215215
$(if $(OPENSHIFT),-nfd.openshift,); \
216216
fi
217217

0 commit comments

Comments
 (0)