Skip to content

Commit 967fa51

Browse files
authored
Merge pull request #1799 from marquiz/release-0.16
[release-0.16] Helm: Add revision history limit for worker daemonset (#1797)
2 parents 6030c97 + 7f53280 commit 967fa51

File tree

4 files changed

+11
-0
lines changed

4 files changed

+11
-0
lines changed

deployment/helm/node-feature-discovery/templates/topologyupdater.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ metadata:
1212
{{- toYaml . | nindent 4 }}
1313
{{- end }}
1414
spec:
15+
revisionHistoryLimit: {{ .Values.topologyUpdater.revisionHistoryLimit }}
1516
selector:
1617
matchLabels:
1718
{{- include "node-feature-discovery.selectorLabels" . | nindent 6 }}

deployment/helm/node-feature-discovery/templates/worker.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ metadata:
1212
{{- toYaml . | nindent 4 }}
1313
{{- end }}
1414
spec:
15+
revisionHistoryLimit: {{ .Values.worker.revisionHistoryLimit }}
1516
selector:
1617
matchLabels:
1718
{{- include "node-feature-discovery.selectorLabels" . | nindent 6 }}

deployment/helm/node-feature-discovery/values.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -425,6 +425,9 @@ worker:
425425
# If not set and create is true, a name is generated using the fullname template
426426
name:
427427

428+
# specify how many old ControllerRevisions for the DaemonSet to retain.
429+
revisionHistoryLimit:
430+
428431
rbac:
429432
create: true
430433

@@ -467,6 +470,10 @@ topologyUpdater:
467470
create: true
468471
annotations: {}
469472
name:
473+
474+
# specify how many old ControllerRevisions for the DaemonSet to retain.
475+
revisionHistoryLimit:
476+
470477
rbac:
471478
create: true
472479

docs/deployment/helm.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ API's you need to install the prometheus operator in your cluster.
167167
| `worker.priorityClassName` | string | | NFD worker pod [priority class](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/) |
168168
| `worker.annotations` | dict | {} | NFD worker pod [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
169169
| `worker.daemonsetAnnotations` | dict | {} | NFD worker daemonset [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
170+
| `worker.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec) |
170171

171172
### Topology updater parameters
172173

@@ -196,6 +197,7 @@ API's you need to install the prometheus operator in your cluster.
196197
| `topologyUpdater.config` | dict | | [configuration](../reference/topology-updater-configuration-reference) |
197198
| `topologyUpdater.podSetFingerprint` | bool | true | Enables compute and report of pod fingerprint in NRT objects. |
198199
| `topologyUpdater.kubeletStateDir` | string | /var/lib/kubelet | Specifies kubelet state directory path for watching state and checkpoint files. Empty value disables kubelet state tracking. |
200+
| `topologyUpdater.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec) |
199201

200202
### Garbage collector parameters
201203

0 commit comments

Comments
 (0)