Skip to content

Commit b06907b

Browse files
authored
Merge pull request #2328 from marquiz/devel/logcheck
scripts/test-infra/verify: re-enable logcheck
2 parents 20064e3 + 4a88560 commit b06907b

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

scripts/test-infra/verify.sh

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --no-default-keyring
1717
curl -Os https://uploader.codecov.io/latest/linux/codecov
1818
chmod +x codecov
1919

20-
# TODO: re-enable logcheck when https://github.com/kubernetes-sigs/logtools/pull/31 is merged
21-
#go install sigs.k8s.io/logtools/logcheck@v0.8.1
20+
# TODO: update logcheck version when there is a new release (newer than v0.9.0)
21+
go install sigs.k8s.io/logtools/logcheck@v0.9.1-0.20251007102500-d35c84c015fe
2222

2323
# Run verify steps
2424
echo "Checking gofmt"
@@ -30,9 +30,8 @@ make ci-lint
3030
echo "Running Helm lint"
3131
make helm-lint
3232

33-
# TODO: re-enable logcheck when https://github.com/kubernetes-sigs/logtools/pull/31 is merged
34-
#echo "Running logcheck"
35-
#logcheck -config "${this_dir}/logcheck.conf" ./cmd/... ./pkg/... ./source/...
33+
echo "Running logcheck"
34+
logcheck -config "${this_dir}/logcheck.conf" ./cmd/... ./pkg/... ./source/...
3635

3736
echo "Running unit tests"
3837
make test

0 commit comments

Comments
 (0)