Skip to content

Commit d963cd3

Browse files
authored
Merge pull request #1895 from marquiz/devel/docs-quoting
docs: quote shell snippets containing urls with query parameters
2 parents 4dbe9c8 + 010393b commit d963cd3

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ features and system configuration!
1212
#### Quick-start – the short-short version
1313

1414
```bash
15-
$ kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref=v0.16.4
15+
$ kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref=v0.16.4"
1616
namespace/node-feature-discovery created
1717
customresourcedefinition.apiextensions.k8s.io/nodefeaturerules.nfd.k8s-sigs.io created
1818
customresourcedefinition.apiextensions.k8s.io/nodefeatures.nfd.k8s-sigs.io created
@@ -38,7 +38,7 @@ $ kubectl -n node-feature-discovery get all
3838
pod/nfd-worker-nwdp6 1/1 Running 0 18s
3939
...
4040

41-
$ kubectl get no -o json | jq '.items[].metadata.labels'
41+
$ kubectl get no -o json | jq ".items[].metadata.labels"
4242
{
4343
"kubernetes.io/arch": "amd64",
4444
"kubernetes.io/os": "linux",

docs/deployment/kustomize.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ later is required.
2626
The kustomize overlays provided in the repo can be used directly:
2727

2828
```bash
29-
kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref={{ site.release }}
29+
kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref={{ site.release }}"
3030
```
3131

3232
This will required RBAC rules and deploy nfd-master (as a deployment) and
@@ -77,7 +77,7 @@ The `default-job` overlay may be used to achieve this:
7777

7878
```bash
7979
NUM_NODES=$(kubectl get no -o jsonpath='{.items[*].metadata.name}' | wc -w)
80-
kubectl kustomize https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default-job?ref={{ site.release }} | \
80+
kubectl kustomize "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default-job?ref={{ site.release }}" | \
8181
sed s"/NUM_NODES/$NUM_NODES/" | \
8282
kubectl apply -f -
8383
```
@@ -94,7 +94,7 @@ deployed as separate pods. The `master-worker-topologyupdater` overlay may be
9494
used to achieve this:
9595

9696
```bash
97-
kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/master-worker-topologyupdater?ref={{ site.release }}
97+
kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/master-worker-topologyupdater?ref={{ site.release }}"
9898

9999
```
100100

@@ -104,7 +104,7 @@ To deploy just nfd-topology-updater (without nfd-master and nfd-worker)
104104
use the `topologyupdater` overlay:
105105

106106
```bash
107-
kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/topologyupdater?ref={{ site.release }}
107+
kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/topologyupdater?ref={{ site.release }}"
108108

109109
```
110110

@@ -114,8 +114,8 @@ are deployed as separate pods;
114114

115115
```bash
116116

117-
kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref={{ site.release }}
118-
kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/topologyupdater?ref={{ site.release }}
117+
kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref={{ site.release }}"
118+
kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/topologyupdater?ref={{ site.release }}"
119119

120120
```
121121

@@ -126,8 +126,8 @@ to scrape metrics from node-feature-discovery,
126126
run the following command:
127127

128128
```bash
129-
kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref={{ site.release }}
130-
kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/prometheus?ref={{ site.release }}
129+
kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref={{ site.release }}"
130+
kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/prometheus?ref={{ site.release }}"
131131
```
132132

133133
## Uninstallation

docs/deployment/uninstallation.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ nfd-related node labels, annotations, extended resources and taints from the
2424
cluster.
2525

2626
```bash
27-
kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/prune?ref={{ site.release }}
27+
kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/prune?ref={{ site.release }}"
2828
kubectl -n node-feature-discovery wait job.batch/nfd-master --for=condition=complete && \
29-
kubectl delete -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/prune?ref={{ site.release }}
29+
kubectl delete -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/prune?ref={{ site.release }}"
3030
```
3131

3232
> **NOTE:** You must run prune before removing the RBAC rules (serviceaccount,

docs/get-started/quick-start.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Deploy with kustomize -- creates a new namespace, service and required RBAC
1414
rules and deploys nfd-master and nfd-worker daemons.
1515

1616
```bash
17-
kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref={{ site.release }}
17+
kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref={{ site.release }}"
1818
```
1919

2020
## Verify
@@ -34,7 +34,7 @@ deployment.apps/nfd-master 1/1 1 1 17s
3434
Check that NFD feature labels have been created
3535

3636
```bash
37-
$ kubectl get no -o json | jq '.items[].metadata.labels'
37+
$ kubectl get no -o json | jq ".items[].metadata.labels"
3838
{
3939
"kubernetes.io/arch": "amd64",
4040
"kubernetes.io/os": "linux",
@@ -82,7 +82,7 @@ To deploy nfd-topology-updater use the `topologyupdater` kustomize
8282
overlay.
8383
8484
```bash
85-
kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/topologyupdater?ref={{ site.release }}
85+
kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/topologyupdater?ref={{ site.release }}"
8686
```
8787
8888
### Verify nfd-topology-updater

0 commit comments

Comments
 (0)